[ovs-dev] daemon-unix: include missing help information
diff mbox series

Message ID 20171211150739.23512-1-aconole@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev] daemon-unix: include missing help information
Related show

Commit Message

Aaron Conole Dec. 11, 2017, 3:07 p.m. UTC
These options have existed for a while, but were not expressed in the
help information.  Inform the user that these options exist, and give
some basic help.

Reported-by: Saravanan KR <skramaja@redhat.com>
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 lib/daemon-unix.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Markos Chandras Dec. 11, 2017, 3:11 p.m. UTC | #1
On 11/12/17 15:07, Aaron Conole wrote:
> These options have existed for a while, but were not expressed in the
> help information.  Inform the user that these options exist, and give
> some basic help.
> 
> Reported-by: Saravanan KR <skramaja@redhat.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>  lib/daemon-unix.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c
> index 967a28432..adb549c98 100644
> --- a/lib/daemon-unix.c
> +++ b/lib/daemon-unix.c
> @@ -537,6 +537,8 @@ daemon_usage(void)
>      printf(
>          "\nDaemon options:\n"
>          "  --detach                run in background as daemon\n"
> +        "  --monitor               creates a process to monitor this daemon\n"
> +        "  --user=username[:group] changes the effective daemon user:group\n"
>          "  --no-chdir              do not chdir to '/'\n"
>          "  --pidfile[=FILE]        create pidfile (default: %s/%s.pid)\n"
>          "  --overwrite-pidfile     with --pidfile, start even if already "
> 

Good catch

Reviewed-by: Markos Chandras <mchandras@suse.de>
Ben Pfaff Dec. 11, 2017, 7:37 p.m. UTC | #2
On Mon, Dec 11, 2017 at 03:11:25PM +0000, Markos Chandras wrote:
> On 11/12/17 15:07, Aaron Conole wrote:
> > These options have existed for a while, but were not expressed in the
> > help information.  Inform the user that these options exist, and give
> > some basic help.
> > 
> > Reported-by: Saravanan KR <skramaja@redhat.com>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
> > ---
> >  lib/daemon-unix.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c
> > index 967a28432..adb549c98 100644
> > --- a/lib/daemon-unix.c
> > +++ b/lib/daemon-unix.c
> > @@ -537,6 +537,8 @@ daemon_usage(void)
> >      printf(
> >          "\nDaemon options:\n"
> >          "  --detach                run in background as daemon\n"
> > +        "  --monitor               creates a process to monitor this daemon\n"
> > +        "  --user=username[:group] changes the effective daemon user:group\n"
> >          "  --no-chdir              do not chdir to '/'\n"
> >          "  --pidfile[=FILE]        create pidfile (default: %s/%s.pid)\n"
> >          "  --overwrite-pidfile     with --pidfile, start even if already "
> > 
> 
> Good catch
> 
> Reviewed-by: Markos Chandras <mchandras@suse.de>

Thanks, Aaron and Markos.  I applied this to master.

Patch
diff mbox series

diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c
index 967a28432..adb549c98 100644
--- a/lib/daemon-unix.c
+++ b/lib/daemon-unix.c
@@ -537,6 +537,8 @@  daemon_usage(void)
     printf(
         "\nDaemon options:\n"
         "  --detach                run in background as daemon\n"
+        "  --monitor               creates a process to monitor this daemon\n"
+        "  --user=username[:group] changes the effective daemon user:group\n"
         "  --no-chdir              do not chdir to '/'\n"
         "  --pidfile[=FILE]        create pidfile (default: %s/%s.pid)\n"
         "  --overwrite-pidfile     with --pidfile, start even if already "