| Message ID | 20171126114524.20819-7-hauke@hauke-m.de |
|---|---|
| State | Superseded |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
| Series | Add support for kernel 4.14 | expand |
Hi Hauke, sch_cake is in major flux at the moment, as it is readied for an attempt at upstreaming. The updated sch_cake from november 25 is not a recommended version to use as far as I can tell. Maybe it would be best to stick to the January version for the few days/weeks it shoud take for the current changes to mature a bit? Best Regards Sebastian > On Nov 26, 2017, at 12:45, Hauke Mehrtens <hauke@hauke-m.de> wrote: > > There are build problems with kernel 4.14, deactivate it for now on this > kernel till someone fixes them. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > package/kernel/kmod-sched-cake/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/kernel/kmod-sched-cake/Makefile b/package/kernel/kmod-sched-cake/Makefile > index ddeff650cc..8a2d277310 100644 > --- a/package/kernel/kmod-sched-cake/Makefile > +++ b/package/kernel/kmod-sched-cake/Makefile > @@ -25,7 +25,7 @@ define KernelPackage/sched-cake > URL:=https://github.com/dtaht/sch_cake > FILES:=$(PKG_BUILD_DIR)/sch_cake.ko > AUTOLOAD:=$(call AutoLoad,75,sch_cake) > - DEPENDS:=+kmod-ipt-conntrack @!LINUX_3_18 > + DEPENDS:=+kmod-ipt-conntrack @!(LINUX_3_18||LINUX_4_14) > endef > > include $(INCLUDE_DIR)/kernel-defaults.mk > -- > 2.11.0 > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev
Hi Sebastian, On 11/26/2017 11:25 PM, Sebastian Moeller wrote: > Hi Hauke, > > sch_cake is in major flux at the moment, as it is readied for an attempt at upstreaming. The updated sch_cake from november 25 is not a recommended version to use as far as I can tell. Maybe it would be best to stick to the January version for the few days/weeks it shoud take for the current changes to mature a bit? I did my patch based on the version from January this was done before the update was added to LEDE, I only compile tested it at that time and there were multiple problems. I just tested it again with the November version and it looks like the compile problem is fixed now, I will drop this patch. If you are aware of more problems it would be nice if they can be fixed. Hauke > > Best Regards > Sebastian > >> On Nov 26, 2017, at 12:45, Hauke Mehrtens <hauke@hauke-m.de> wrote: >> >> There are build problems with kernel 4.14, deactivate it for now on this >> kernel till someone fixes them. >> >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >> --- >> package/kernel/kmod-sched-cake/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/kernel/kmod-sched-cake/Makefile b/package/kernel/kmod-sched-cake/Makefile >> index ddeff650cc..8a2d277310 100644 >> --- a/package/kernel/kmod-sched-cake/Makefile >> +++ b/package/kernel/kmod-sched-cake/Makefile >> @@ -25,7 +25,7 @@ define KernelPackage/sched-cake >> URL:=https://github.com/dtaht/sch_cake >> FILES:=$(PKG_BUILD_DIR)/sch_cake.ko >> AUTOLOAD:=$(call AutoLoad,75,sch_cake) >> - DEPENDS:=+kmod-ipt-conntrack @!LINUX_3_18 >> + DEPENDS:=+kmod-ipt-conntrack @!(LINUX_3_18||LINUX_4_14) >> endef >> >> include $(INCLUDE_DIR)/kernel-defaults.mk
Hauke Mehrtens <hauke@hauke-m.de> writes: > Hi Sebastian, > > On 11/26/2017 11:25 PM, Sebastian Moeller wrote: >> Hi Hauke, >> >> sch_cake is in major flux at the moment, as it is readied for an attempt at >> upstreaming. The updated sch_cake from november 25 is not a recommended >> version to use as far as I can tell. Maybe it would be best to stick to the >> January version for the few days/weeks it shoud take for the current changes >> to mature a bit? > > I did my patch based on the version from January this was done before > the update was added to LEDE, I only compile tested it at that time and > there were multiple problems. I just tested it again with the November > version and it looks like the compile problem is fixed now, I will drop > this patch. > > If you are aware of more problems it would be nice if they can be fixed. If there are any more issues with cake in lede, please let us know either via github or the cake mailing list... Cake is starting to settle down a bit (in the cobalt branch), and should compile all the way back to 3.10 now. (I think). My intent is to attempt upstreaming next week, and try to fix all the problems revealed that way, then resume the backporting effort. The only major new feature is "ack filtering", with several bug fixes and performance enhancements, along with a lot of checkpatch related grief being fixed. So I too would advise steering clear of the churn for a bit, but certainly feel free to play with where we're at. git clone -b cobalt https://github.com/dtaht/sch_cake.git git clone https://github.com/dtaht/iproute2-cake-next.git > > Hauke > >> >> Best Regards >> Sebastian >> >>> On Nov 26, 2017, at 12:45, Hauke Mehrtens <hauke@hauke-m.de> wrote: >>> >>> There are build problems with kernel 4.14, deactivate it for now on this >>> kernel till someone fixes them. >>> >>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >>> --- >>> package/kernel/kmod-sched-cake/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/package/kernel/kmod-sched-cake/Makefile b/package/kernel/kmod-sched-cake/Makefile >>> index ddeff650cc..8a2d277310 100644 >>> --- a/package/kernel/kmod-sched-cake/Makefile >>> +++ b/package/kernel/kmod-sched-cake/Makefile >>> @@ -25,7 +25,7 @@ define KernelPackage/sched-cake >>> URL:=https://github.com/dtaht/sch_cake >>> FILES:=$(PKG_BUILD_DIR)/sch_cake.ko >>> AUTOLOAD:=$(call AutoLoad,75,sch_cake) >>> - DEPENDS:=+kmod-ipt-conntrack @!LINUX_3_18 >>> + DEPENDS:=+kmod-ipt-conntrack @!(LINUX_3_18||LINUX_4_14) >>> endef >>> >>> include $(INCLUDE_DIR)/kernel-defaults.mk > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev
diff --git a/package/kernel/kmod-sched-cake/Makefile b/package/kernel/kmod-sched-cake/Makefile index ddeff650cc..8a2d277310 100644 --- a/package/kernel/kmod-sched-cake/Makefile +++ b/package/kernel/kmod-sched-cake/Makefile @@ -25,7 +25,7 @@ define KernelPackage/sched-cake URL:=https://github.com/dtaht/sch_cake FILES:=$(PKG_BUILD_DIR)/sch_cake.ko AUTOLOAD:=$(call AutoLoad,75,sch_cake) - DEPENDS:=+kmod-ipt-conntrack @!LINUX_3_18 + DEPENDS:=+kmod-ipt-conntrack @!(LINUX_3_18||LINUX_4_14) endef include $(INCLUDE_DIR)/kernel-defaults.mk
There are build problems with kernel 4.14, deactivate it for now on this kernel till someone fixes them. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- package/kernel/kmod-sched-cake/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)