| Message ID | 20171121034913.3237-1-rosenp@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | John Crispin |
| Headers | show |
| Series | [LEDE-DEV] samba36: Disable by default | expand |
Rosen Penev <rosenp@gmail.com> wrote: > sendfile has been tested to have stability issues with at least > mt7621 and mvebu. With both, I've had the system reboot(no logs > unfortunately). It usually happens when seeking multiple times > with a single video file. A different user said disabling > sendfile improved her uptime from a few hours to around 10 > days. Do you have a ticket for this? this would seem to be a bigger problem than just samba, and should get solved via something more than just disabling one part of samba. Also, I find it hard to believe that sendfile would be broken on alllll platforms. Sincerely, Karl Palsson
On an archer-c7-v2 running 17.01.2 and samba with "use sendfile" enabled, no problems have been noticed (long up-time). S.y. Paul > Op 21 nov. 2017, om 10:34 heeft Karl Palsson <karlp@tweak.net.au> het volgende geschreven: > > > Rosen Penev <rosenp@gmail.com> wrote: >> sendfile has been tested to have stability issues with at least >> mt7621 and mvebu. With both, I've had the system reboot(no logs >> unfortunately). It usually happens when seeking multiple times >> with a single video file. A different user said disabling >> sendfile improved her uptime from a few hours to around 10 >> days. > > Do you have a ticket for this? this would seem to be a bigger > problem than just samba, and should get solved via something more > than just disabling one part of samba. Also, I find it hard to > believe that sendfile would be broken on alllll platforms. > > Sincerely, > Karl Palsson_______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev
On 22.11.2017 16:20, Paul Oranje wrote: > On an archer-c7-v2 running 17.01.2 and samba with "use sendfile" enabled, no problems have been noticed (long up-time). > S.y. Paul > >> Op 21 nov. 2017, om 10:34 heeft Karl Palsson <karlp@tweak.net.au> het volgende geschreven: >> >> >> Rosen Penev <rosenp@gmail.com> wrote: >>> sendfile has been tested to have stability issues with at least >>> mt7621 and mvebu. With both, I've had the system reboot(no logs >>> unfortunately). It usually happens when seeking multiple times >>> with a single video file. A different user said disabling >>> sendfile improved her uptime from a few hours to around 10 >>> days. >> Do you have a ticket for this? this would seem to be a bigger >> problem than just samba, and should get solved via something more >> than just disabling one part of samba. Also, I find it hard to >> believe that sendfile would be broken on alllll platforms. >> >> Sincerely, >> Karl Palsson_______________________________________________ >> Lede-dev mailing list >> Lede-dev@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/lede-dev > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev never had problems with samba and sendfile was always yes, even with hundred of days of uptime but very few users (x86 & mvebu, win 7,10,2016,xp) Regards
No problem with "use sendfile = yes" on bcm53xx platform, arm_cortex-a9, LEDE SNAPSHOT r5297-bddffc5 (and preceding development releases), running for a long time (weeks or months), used daily by several users. On 21 November 2017 at 04:34, Karl Palsson <karlp@tweak.net.au> wrote: > > Rosen Penev <rosenp@gmail.com> wrote: >> sendfile has been tested to have stability issues with at least >> mt7621 and mvebu. With both, I've had the system reboot(no logs >> unfortunately). It usually happens when seeking multiple times >> with a single video file. A different user said disabling >> sendfile improved her uptime from a few hours to around 10 >> days. > > Do you have a ticket for this? this would seem to be a bigger > problem than just samba, and should get solved via something more > than just disabling one part of samba. Also, I find it hard to > believe that sendfile would be broken on alllll platforms. > > Sincerely, > Karl Palsson > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev >
diff --git a/package/network/services/samba36/Makefile b/package/network/services/samba36/Makefile index 5564a78404..42c23b4e8e 100644 --- a/package/network/services/samba36/Makefile +++ b/package/network/services/samba36/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=samba PKG_VERSION:=3.6.25 -PKG_RELEASE:=8 +PKG_RELEASE:=9 PKG_SOURCE_URL:=https://download.samba.org/pub/samba \ https://download.samba.org/pub/samba/stable diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template index fc72f9258c..36bf73039d 100644 --- a/package/network/services/samba36/files/smb.conf.template +++ b/package/network/services/samba36/files/smb.conf.template @@ -17,4 +17,4 @@ passdb backend = smbpasswd security = user smb passwd file = /etc/samba/smbpasswd - use sendfile = yes + use sendfile = no ;unstable - enable at your own risk
sendfile has been tested to have stability issues with at least mt7621 and mvebu. With both, I've had the system reboot(no logs unfortunately). It usually happens when seeking multiple times with a single video file. A different user said disabling sendfile improved her uptime from a few hours to around 10 days. Disable and add a comment warning the user. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- package/network/services/samba36/Makefile | 2 +- package/network/services/samba36/files/smb.conf.template | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)