Message ID | 1510326972-26479-2-git-send-email-i.maximets@samsung.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="unknown key hash" (0-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="KTKhoeIp"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yYNtd53R8z9sRm for <incoming@patchwork.ozlabs.org>; Sat, 11 Nov 2017 02:17:13 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id EBB1BAF5; Fri, 10 Nov 2017 15:16:27 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 78AA0AF5 for <ovs-dev@openvswitch.org>; Fri, 10 Nov 2017 15:16:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DB5C68A for <ovs-dev@openvswitch.org>; Fri, 10 Nov 2017 15:16:25 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20171110151623euoutp02010d4e78ce07de55febfb433e1527261~1wmOpfgQF1840618406euoutp02U; Fri, 10 Nov 2017 15:16:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20171110151623euoutp02010d4e78ce07de55febfb433e1527261~1wmOpfgQF1840618406euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1510326983; bh=nQ8dvX8LVxwLnjqv3OGZyK7Rvz87nGLFINO1sPwD898=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=KTKhoeIpHbxfMg+LwKv3EYd6RUM3OLomfD9Q+vKUe2S2lOQ5N/G4BQYFMC/M5KIkf vNU0OSi6j/QAZhFGfBJvvyjbXfA6lxzFNcgGPIR6Ow3N0A1s7kXYSoYCqW7SMczWV2 IqBzxL8oIXAcOGM+TE6JToRS20tBsnYGF8btZzqw= Received: from eusmges4.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171110151622eucas1p2b79be2f480868fd11b4bb3b56207e499~1wmN9cRDG0625506255eucas1p2V; Fri, 10 Nov 2017 15:16:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges4.samsung.com (EUCPMTA) with SMTP id 06.13.12944.6C2C50A5; Fri, 10 Nov 2017 15:16:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171110151621eucas1p2073472221af40a7f0878de538187bda7~1wmNEI7zR1192911929eucas1p2A; Fri, 10 Nov 2017 15:16:21 +0000 (GMT) X-AuditID: cbfec7f4-f79ab6d000003290-05-5a05c2c6b72f Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B2.26.18832.5C2C50A5; Fri, 10 Nov 2017 15:16:21 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OZ7008MUJR2YR00@eusync1.samsung.com>; Fri, 10 Nov 2017 15:16:21 +0000 (GMT) From: Ilya Maximets <i.maximets@samsung.com> To: ovs-dev@openvswitch.org Date: Fri, 10 Nov 2017 18:16:10 +0300 Message-id: <1510326972-26479-2-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1510326972-26479-1-git-send-email-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWy7djPc7rHDrFGGfy/KWqx+henRUv/TGaL aZ9vs1tcaf/JbrHx4VlWixU3TjFazP30nNHi9dF/zA4cHov3vGTyeHbzP6NH35ZVjAHMUVw2 Kak5mWWpRfp2CVwZ9y62sBbM4a7oXLiYtYHxM0cXIyeHhICJxJRVW9ggbDGJC/fWA9lcHEIC Sxkl7v09ygrhfGaUONvZxgzT8eXWJxaIxDJGiW1nHkE5zUwSv9edYgGpYhPQkTi1+ggjiC0i IC3xuvcN2Chmge1MEpvvnAJbKCzgIbH23hVWEJtFQFXi4O6b7CA2r4CbxL+j21kg1slJ3DzX CbaaU8Bd4tbBCWCDJAQ62CRWv26CuslF4t6+00wQtrDEq+Nb2CFsGYnOjoNMEA3NjBINqy4x QjgTGCW+NC+H6rCXOHXzKpjNLMAnMWnbdKCpHEBxXomONiEI00Pi8bZIiGpHiWVLzjFBvDyL UWL96wlMExilFzAyrGIUSS0tzk1PLTbRK07MLS7NS9dLzs/dxAiM0tP/jn/Zwbj4mNUhRgEO RiUe3g93WaKEWBPLiitzDzFKcDArifAGzmONEuJNSaysSi3Kjy8qzUktPsQozcGiJM5rG9UW KSSQnliSmp2aWpBaBJNl4uCUamA0n2gYsO/VF/55K99+PvRsZokqyxTW19IyTgWl2rlTbB4u 3fM3RK7n/rvtLWb//hQe4fqy/c4nh6Ltdy7eDD38zW/K9LMHXkh4RxdUJ10M4Xys83zPCb3r T5+GySQt8X8eac5m/em9Z1d3QVuj/b0tDBU3eF4zbrphItpj+lNH8aZmXO288P+ZSizFGYmG WsxFxYkAcEcMoc4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42I5/e/4Zd2jh1ijDObuUrNY/YvToqV/JrPF tM+32S2utP9kt9j48CyrxYobpxgt5n56zmjx+ug/ZgcOj8V7XjJ5PLv5n9Gjb8sqxgDmKC6b lNSczLLUIn27BK6MexdbWAvmcFd0LlzM2sD4maOLkZNDQsBE4sutTywQtpjEhXvr2boYuTiE BJYwSjxYtYgFwmllknhysp8dpIpNQEfi1OojjCC2iIC0xOveN6wgRcwCO5kkHvY8AksIC3hI rL13hRXEZhFQlTi4+yZYM6+Am8S/o9uh1slJ3DzXyQxicwq4S9w6OAGsXgioZsL89WwTGHkX MDKsYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECAymbcd+bt7BeGlj8CFGAQ5GJR5ejwcsUUKs iWXFlbmHGCU4mJVEeAPnsUYJ8aYkVlalFuXHF5XmpBYfYpTmYFES5+3dszpSSCA9sSQ1OzW1 ILUIJsvEwSnVwFghrGA0kzHIxLrt8UL9x8/eblr2foPgNqbMcmk7WyEV7kdhGYuaD86vU33T c/HSyykH5s8JlGN0tyrLO64j7SKim/oge/ONj8rdqz8GvlmZp7WyQ+RIzJRV7AIeZ8RNtTO2 zZCpcNzQd7tX/iTj+7K2q0VCv5fIW17+mntyMktE0bmC/JIVVkosxRmJhlrMRcWJAIB5dJYi AgAA X-CMS-MailID: 20171110151621eucas1p2073472221af40a7f0878de538187bda7 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171110151621eucas1p2073472221af40a7f0878de538187bda7 X-RootMTR: 20171110151621eucas1p2073472221af40a7f0878de538187bda7 References: <1510326972-26479-1-git-send-email-i.maximets@samsung.com> <CGME20171110151621eucas1p2073472221af40a7f0878de538187bda7@eucas1p2.samsung.com> X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Robert Wojciechowicz <robertx.wojciechowicz@intel.com>, Heetae Ahn <heetae82.ahn@samsung.com>, Ilya Maximets <i.maximets@samsung.com> Subject: [ovs-dev] [PATCH v3 1/3] netdev-dpdk: Fix dpdk_mp leak in case of EEXIST. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
Series |
netdev-dpdk: mempool management: Leaks & Refactoring.
|
expand
|
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 76e79be..ad52a03 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -659,6 +659,12 @@ netdev_dpdk_mempool_configure(struct netdev_dpdk *dev) * Update dev with the new values. */ dev->mtu = dev->requested_mtu; dev->max_packet_len = MTU_TO_FRAME_LEN(dev->mtu); + /* 'mp' should contain pointer to the mempool already owned by netdev. + * Otherwise something went completely wrong. */ + ovs_assert(dev->dpdk_mp); + ovs_assert(dev->dpdk_mp->mp == mp->mp); + /* Free the returned struct dpdk_mp because it will not be used. */ + rte_free(mp); return EEXIST; } else { /* A new mempool was created, release the previous one. */