[net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map

Message ID 1509150502-6632-1-git-send-email-tushar.n.dave@oracle.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map
Related show

Commit Message

Tushar Dave Oct. 28, 2017, 12:28 a.m.
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
e.g.
[root@labbpf]# ./xdp_redirect_map $(</sys/class/net/eth2/ifindex) \
> $(</sys/class/net/eth3/ifindex)
failed to create a map: 1 Operation not permitted

The failure is 100% when multiple xdp programs are running. Fix it.

Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
---
 samples/bpf/xdp_redirect_map_user.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Alexei Starovoitov Oct. 28, 2017, 1:59 a.m. | #1
On Fri, Oct 27, 2017 at 05:28:22PM -0700, Tushar Dave wrote:
> Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
> e.g.
> [root@labbpf]# ./xdp_redirect_map $(</sys/class/net/eth2/ifindex) \
> > $(</sys/class/net/eth3/ifindex)
> failed to create a map: 1 Operation not permitted
> 
> The failure is 100% when multiple xdp programs are running. Fix it.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>

Acked-by: Alexei Starovoitov <ast@kernel.org>
David Miller Oct. 29, 2017, 3:18 a.m. | #2
From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Fri, 27 Oct 2017 17:28:22 -0700

> Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
> e.g.
> [root@labbpf]# ./xdp_redirect_map $(</sys/class/net/eth2/ifindex) \
>> $(</sys/class/net/eth3/ifindex)
> failed to create a map: 1 Operation not permitted
> 
> The failure is 100% when multiple xdp programs are running. Fix it.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>

Applied.

Patch

diff --git a/samples/bpf/xdp_redirect_map_user.c b/samples/bpf/xdp_redirect_map_user.c
index d4d86a2..978a532 100644
--- a/samples/bpf/xdp_redirect_map_user.c
+++ b/samples/bpf/xdp_redirect_map_user.c
@@ -20,6 +20,7 @@ 
 #include <string.h>
 #include <unistd.h>
 #include <libgen.h>
+#include <sys/resource.h>
 
 #include "bpf_load.h"
 #include "bpf_util.h"
@@ -74,6 +75,7 @@  static void usage(const char *prog)
 
 int main(int argc, char **argv)
 {
+	struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
 	const char *optstr = "SN";
 	char filename[256];
 	int ret, opt, key = 0;
@@ -97,6 +99,11 @@  int main(int argc, char **argv)
 		return 1;
 	}
 
+	if (setrlimit(RLIMIT_MEMLOCK, &r)) {
+		perror("setrlimit(RLIMIT_MEMLOCK)");
+		return 1;
+	}
+
 	ifindex_in = strtoul(argv[optind], NULL, 0);
 	ifindex_out = strtoul(argv[optind + 1], NULL, 0);
 	printf("input: %d output: %d\n", ifindex_in, ifindex_out);