From patchwork Thu Oct 19 22:46:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 828401 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ZKh13kNB"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yJ3wf0XPvz9t7V for ; Fri, 20 Oct 2017 09:47:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbdJSWrk (ORCPT ); Thu, 19 Oct 2017 18:47:40 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:48373 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbdJSWrJ (ORCPT ); Thu, 19 Oct 2017 18:47:09 -0400 Received: by mail-pf0-f195.google.com with SMTP id b79so8111760pfk.5 for ; Thu, 19 Oct 2017 15:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j633OgtARII1ZVsVBuR64FHXmkbgTmAhaBDhn64gxeY=; b=ZKh13kNBSxiullIVrbBPvmsX2rhtC+xXCXLgLl7YLEKfvTsQ7oqouDKZvo0C6ffbJ4 NiXA4CcP62WK/v2bk+sibf82LO6dHsAHIPClIRVoHlpREVfIZJ9plfq5szXfM9tMMO5l iHycpKh7RS8aO0YzkFTmFPPVWA4KrN+qS5wCZmfbTAEKVOS3Nza/j/gRBS3mimbPHznA YNMUCFDmxrNIllSiH432mGGOpYzRhbmNQxlqXaOQkcqdiMDAUo9KQ/pvy9GX+WXE1IpO G2AdeILrbxzl3RqUB34g08ybBJQ8PslOe9+V2hATpLh6pZU4K7HwF2g30PNOk9wMiuQ3 gShw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j633OgtARII1ZVsVBuR64FHXmkbgTmAhaBDhn64gxeY=; b=UNdFEYkvbynvem7+TFQUv8jrHmBeQjSIv9WyEaGxo5OUbEnPeaLzZB3ekC9r/n7vSx qhBVXDbuMUYamQx82djBkCcmfl950IMkOOq+T8WpNMha8ntPd3aLZvL/t+ID1apHypoa 4yP2AbKV68+IrR1XxnwcafYwuOn+C8yoXPpMwAj92127nA24wDF2/eogJWkl6IXW8dzy k0TQro0ms/4MpvZq19i5qf4JVv95G03NrHYc1xlEDcSY3nAy5zNXgiw5pwTb4+Z/ALHo E/Af0MiktXASYBNEXSgN6XpS6DRTqkaZwq3EcmUNLfq3kench82Yc7Lv/1/s93QWwS4v mAnw== X-Gm-Message-State: AMCzsaVtn5PdNocMOPRPzZ0Nb0RAhp7wSZdntMZoG4zdQ/1jYKrrZ/Ky BUR4WJr7/3E2HtdDju7KjJdeHqH/ X-Google-Smtp-Source: ABhQp+TRjGJdJQfqWjopewJTUIwxZZGIfJSZU4b+kbP0ZRgJSOT0YiEoaiwiwk1QriCzLw8gJ5+6PQ== X-Received: by 10.99.63.199 with SMTP id m190mr2631852pga.239.1508453228848; Thu, 19 Oct 2017 15:47:08 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id c185sm16969156pfb.112.2017.10.19.15.47.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Oct 2017 15:47:08 -0700 (PDT) From: Jakub Kicinski To: netdev@vger.kernel.org Cc: oss-drivers@netronome.com, Quentin Monnet , Jakub Kicinski Subject: [PATCH net-next 4/8] tools: bpftool: add `bpftool prog help` as real command i.r.t exit code Date: Thu, 19 Oct 2017 15:46:22 -0700 Message-Id: <20171019224626.31608-5-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171019224626.31608-1-jakub.kicinski@netronome.com> References: <20171019224626.31608-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Quentin Monnet Make error messages and return codes more consistent. Specifically, make `bpftool prog help` a real command, instead of printing usage by default for a non-recognized "help" command. Output is the same, but this makes bpftool return with a success value instead of an error. Signed-off-by: Quentin Monnet Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- tools/bpf/bpftool/prog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index 6c03d2ea3f79..355c14325622 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -475,6 +475,7 @@ static int do_help(int argc, char **argv) static const struct cmd cmds[] = { { "show", do_show }, + { "help", do_help }, { "dump", do_dump }, { "pin", do_pin }, { 0 }