| Message ID | 20170922155023.15821-1-colin.king@canonical.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | hv_netvsc: make const array ver_list static, reduces object code size | expand |
> -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: Friday, September 22, 2017 8:50 AM > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>; > devel@linuxdriverproject.org; netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] hv_netvsc: make const array ver_list static, reduces > object code size > > From: Colin Ian King <colin.king@canonical.com> > > Don't populate const array ver_list on the stack, instead make it > static. Makes the object code smaller by over 400 bytes: > > Before: > text data bss dec hex filename > 18444 3168 320 21932 55ac > drivers/net/hyperv/netvsc.o > > After: > text data bss dec hex filename > 17950 3224 320 21494 53f6 > drivers/net/hyperv/netvsc.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
From: Colin King <colin.king@canonical.com> Date: Fri, 22 Sep 2017 16:50:23 +0100 > From: Colin Ian King <colin.king@canonical.com> > > Don't populate const array ver_list on the stack, instead make it > static. Makes the object code smaller by over 400 bytes: > > Before: > text data bss dec hex filename > 18444 3168 320 21932 55ac drivers/net/hyperv/netvsc.o > > After: > text data bss dec hex filename > 17950 3224 320 21494 53f6 drivers/net/hyperv/netvsc.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to net-next, thanks.
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 8d5077fb0492..b0d323e24978 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -484,7 +484,7 @@ static int netvsc_connect_vsp(struct hv_device *device, struct netvsc_device *net_device, const struct netvsc_device_info *device_info) { - const u32 ver_list[] = { + static const u32 ver_list[] = { NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2, NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5 };