Message ID | 20170922154014.29350-3-f4bug@amsat.org |
---|---|
State | Superseded, archived |
Headers | show |
Series | remove i386/pc dependency from non-PC world (part 1) | expand |
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > while here, add entries for ppc4xx_i2c in MAINTAINERS > > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- This is doing two things at once and would ideally be two patches. Still, Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 09/22/2017 11:07 AM, Peter Maydell wrote: > On 22 September 2017 at 16:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> while here, add entries for ppc4xx_i2c in MAINTAINERS >> >> applied using ./scripts/clean-includes >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- > This is doing two things at once and would ideally be > two patches. Still, I agree. > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> I applied this series and did some basic testing, so Reviewed-by: Corey Minyard <cminyard@mvista.com> Tested-by: Corey Minyard <cminyard@mvista.com> > thanks > -- PMM >
On 09/22/2017 01:07 PM, Peter Maydell wrote: > On 22 September 2017 at 16:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> while here, add entries for ppc4xx_i2c in MAINTAINERS >> >> applied using ./scripts/clean-includes >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- > > This is doing two things at once and would ideally be > two patches. Still, OK I'll split "while here" patches. > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Thanks!
diff --git a/include/hw/acpi/ipmi.h b/include/hw/acpi/ipmi.h index ab2bb29048..c38483565c 100644 --- a/include/hw/acpi/ipmi.h +++ b/include/hw/acpi/ipmi.h @@ -9,7 +9,6 @@ #ifndef HW_ACPI_IPMI_H #define HW_ACPI_IPMI_H -#include "qemu/osdep.h" #include "hw/acpi/aml-build.h" /* diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h index 79ac79c29c..b7470644d8 100644 --- a/include/hw/cpu/core.h +++ b/include/hw/cpu/core.h @@ -9,7 +9,6 @@ #ifndef HW_CPU_CORE_H #define HW_CPU_CORE_H -#include "qemu/osdep.h" #include "hw/qdev.h" #define TYPE_CPU_CORE "cpu-core" diff --git a/include/hw/i2c/ppc4xx_i2c.h b/include/hw/i2c/ppc4xx_i2c.h index e53042f6d4..3450bda577 100644 --- a/include/hw/i2c/ppc4xx_i2c.h +++ b/include/hw/i2c/ppc4xx_i2c.h @@ -25,7 +25,6 @@ #ifndef PPC4XX_I2C_H #define PPC4XX_I2C_H -#include "qemu/osdep.h" #include "qemu-common.h" #include "hw/sysbus.h" #include "hw/i2c/i2c.h" diff --git a/MAINTAINERS b/MAINTAINERS index 762e37bfd6..7f49f1d046 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -945,7 +945,9 @@ M: Alexander Graf <agraf@suse.de> L: qemu-ppc@nongnu.org S: Odd Fixes F: hw/ppc/ppc4*.c +F: hw/i2c/ppc4xx_i2c.c F: include/hw/ppc/ppc4xx.h +F: include/hw/i2c/ppc4xx_i2c.h ppce500 M: Alexander Graf <agraf@suse.de>
while here, add entries for ppc4xx_i2c in MAINTAINERS applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- Zoltán you might want to add yourself a reviewer entry on ppc4xx :) R: Balaton Zoltan <balaton@eik.bme.hu> include/hw/acpi/ipmi.h | 1 - include/hw/cpu/core.h | 1 - include/hw/i2c/ppc4xx_i2c.h | 1 - MAINTAINERS | 2 ++ 4 files changed, 2 insertions(+), 3 deletions(-)