| Message ID | 1506005428.29839.129.camel@edumazet-glaptop3.roam.corp.google.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: vrf: remove skb_dst_force() after skb_dst_set() | expand |
On 9/21/17 8:50 AM, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@google.com> > > skb_dst_set(skb, dst) installs a normal (refcounted) dst, there is no > point using skb_dst_force(skb) > > Signed-off-by: Eric Dumazet <edumazet@google.com> > --- > drivers/net/vrf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index 9b243e6f3008bb5319844412cd49db1cd7bce594..cc18b7b11612d16271a1dbbb2d55c8f61781b9be 100644 > --- a/drivers/net/vrf.c > +++ b/drivers/net/vrf.c > @@ -132,7 +132,6 @@ static int vrf_local_xmit(struct sk_buff *skb, struct net_device *dev, > skb_orphan(skb); > > skb_dst_set(skb, dst); > - skb_dst_force(skb); > > /* set pkt_type to avoid skb hitting packet taps twice - > * once on Tx and again in Rx processing > > Acked-by: David Ahern <dsa@cumulusnetworks.com>
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Thu, 21 Sep 2017 07:50:28 -0700 > From: Eric Dumazet <edumazet@google.com> > > skb_dst_set(skb, dst) installs a normal (refcounted) dst, there is no > point using skb_dst_force(skb) > > Signed-off-by: Eric Dumazet <edumazet@google.com> Applied, thanks Eric.
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 9b243e6f3008bb5319844412cd49db1cd7bce594..cc18b7b11612d16271a1dbbb2d55c8f61781b9be 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -132,7 +132,6 @@ static int vrf_local_xmit(struct sk_buff *skb, struct net_device *dev, skb_orphan(skb); skb_dst_set(skb, dst); - skb_dst_force(skb); /* set pkt_type to avoid skb hitting packet taps twice - * once on Tx and again in Rx processing