| Message ID | 20170830230357.5440-1-kumaranand@vmware.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx | expand |
Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx
Only curNbl in the forwarding context needs to be updated with
fragmented NBL.
Signed-off-by: Anand Kumar <kumaranand@vmware.com>
Good catch. Acked-by: Sairam Venugopal <vsairam@vmware.com> On 8/30/17, 4:03 PM, "ovs-dev-bounces@openvswitch.org on behalf of Anand Kumar" <ovs-dev-bounces@openvswitch.org on behalf of kumaranand@vmware.com> wrote: >Only curNbl in the forwarding context needs to be updated with >fragmented NBL. > >Signed-off-by: Anand Kumar <kumaranand@vmware.com> >--- > datapath-windows/ovsext/Actions.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c >index 684b316..41d1c7b 100644 >--- a/datapath-windows/ovsext/Actions.c >+++ b/datapath-windows/ovsext/Actions.c >@@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext *ovsFwdCtx, UINT16 mru) > > if (fragNbl != NULL) { > OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl, TRUE); >- OvsInitForwardingCtx(ovsFwdCtx, >- ovsFwdCtx->switchContext, >- fragNbl, >- ovsFwdCtx->srcVportNo, >- ovsFwdCtx->sendFlags, >- NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl), >- ovsFwdCtx->completionList, >- &ovsFwdCtx->layers, FALSE); >+ ovsFwdCtx->curNbl = fragNbl; > } else { > OVS_LOG_INFO("Fragment NBL failed for MRU = %u", mru); > } >-- >2.9.3.windows.1 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=Blm4rRbJawNtVUIwJBOWdpXZXYoC5m1pWTeIwnTXzrw&s=nFm5w0cTb7IN2ZR5CyOtAHQq6desheZnbuNYTFg0SYc&e=
I also tested with an Openstack environment with two nodes. Acked-by: Alin Gabriel Serdean <aserdean@ovn.org> > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, August 31, 2017 2:04 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to > OvsInitForwardingCtx > > Only curNbl in the forwarding context needs to be updated with fragmented > NBL. > > Signed-off-by: Anand Kumar <kumaranand@vmware.com> > --- > datapath-windows/ovsext/Actions.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/datapath-windows/ovsext/Actions.c b/datapath- > windows/ovsext/Actions.c > index 684b316..41d1c7b 100644 > --- a/datapath-windows/ovsext/Actions.c > +++ b/datapath-windows/ovsext/Actions.c > @@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext > *ovsFwdCtx, UINT16 mru) > > if (fragNbl != NULL) { > OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl, > TRUE); > - OvsInitForwardingCtx(ovsFwdCtx, > - ovsFwdCtx->switchContext, > - fragNbl, > - ovsFwdCtx->srcVportNo, > - ovsFwdCtx->sendFlags, > - NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl), > - ovsFwdCtx->completionList, > - &ovsFwdCtx->layers, FALSE); > + ovsFwdCtx->curNbl = fragNbl; > } else { > OVS_LOG_INFO("Fragment NBL failed for MRU = %u", mru); > } > -- > 2.9.3.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I applied this on master and branch-2.8. Thanks, Alin. > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, August 31, 2017 2:04 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to > OvsInitForwardingCtx > > Only curNbl in the forwarding context needs to be updated with fragmented > NBL. > > Signed-off-by: Anand Kumar <kumaranand@vmware.com> > --- > datapath-windows/ovsext/Actions.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/datapath-windows/ovsext/Actions.c b/datapath- > windows/ovsext/Actions.c > index 684b316..41d1c7b 100644 > --- a/datapath-windows/ovsext/Actions.c > +++ b/datapath-windows/ovsext/Actions.c > @@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext > *ovsFwdCtx, UINT16 mru) > > if (fragNbl != NULL) { > OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl, > TRUE); > - OvsInitForwardingCtx(ovsFwdCtx, > - ovsFwdCtx->switchContext, > - fragNbl, > - ovsFwdCtx->srcVportNo, > - ovsFwdCtx->sendFlags, > - NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl), > - ovsFwdCtx->completionList, > - &ovsFwdCtx->layers, FALSE); > + ovsFwdCtx->curNbl = fragNbl; > } else { > OVS_LOG_INFO("Fragment NBL failed for MRU = %u", mru); > } > -- > 2.9.3.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index 684b316..41d1c7b 100644 --- a/datapath-windows/ovsext/Actions.c +++ b/datapath-windows/ovsext/Actions.c @@ -160,14 +160,7 @@ OvsDoFragmentNbl(OvsForwardingContext *ovsFwdCtx, UINT16 mru) if (fragNbl != NULL) { OvsCompleteNBL(ovsFwdCtx->switchContext, ovsFwdCtx->curNbl, TRUE); - OvsInitForwardingCtx(ovsFwdCtx, - ovsFwdCtx->switchContext, - fragNbl, - ovsFwdCtx->srcVportNo, - ovsFwdCtx->sendFlags, - NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(fragNbl), - ovsFwdCtx->completionList, - &ovsFwdCtx->layers, FALSE); + ovsFwdCtx->curNbl = fragNbl; } else { OVS_LOG_INFO("Fragment NBL failed for MRU = %u", mru); }
Only curNbl in the forwarding context needs to be updated with fragmented NBL. Signed-off-by: Anand Kumar <kumaranand@vmware.com> --- datapath-windows/ovsext/Actions.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)