diff mbox series

[1/1] grub2: force -fno-stack-protector in CFLAGS

Message ID 20170830014756.1025-1-nunes.erico@gmail.com
State Accepted
Headers show
Series [1/1] grub2: force -fno-stack-protector in CFLAGS | expand

Commit Message

Erico Nunes Aug. 30, 2017, 1:47 a.m. UTC
grub2 fails to configure when BR2_SSP_ALL is enabled, with the following
configure error:

  checking whether -fno-asynchronous-unwind-tables works... yes
  checking whether -fno-unwind-tables works... yes
  checking for target linking format... unknown
  configure: error: no suitable link format found

This can be worked around by enforcing -fno-stack-protector in the
package CFLAGS in a way that overrides the SSP flag, as is already done
for the valgrind package.

Fixes bug #10261.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reported-by: Dr I J Ormshaw <ian_ormshaw@waters.com>
---
 boot/grub2/grub2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Sept. 6, 2017, 11:30 a.m. UTC | #1
>>>>> "Erico" == Erico Nunes <nunes.erico@gmail.com> writes:

 > grub2 fails to configure when BR2_SSP_ALL is enabled, with the following
 > configure error:

 >   checking whether -fno-asynchronous-unwind-tables works... yes
 >   checking whether -fno-unwind-tables works... yes
 >   checking for target linking format... unknown
 >   configure: error: no suitable link format found

 > This can be worked around by enforcing -fno-stack-protector in the
 > package CFLAGS in a way that overrides the SSP flag, as is already done
 > for the valgrind package.

 > Fixes bug #10261.

 > Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
 > Reported-by: Dr I J Ormshaw <ian_ormshaw@waters.com>

Committed to 2017.02.x, thanks.
diff mbox series

Patch

diff --git a/boot/grub2/grub2.mk b/boot/grub2/grub2.mk
index 36f27d14ea..492cddf1a5 100644
--- a/boot/grub2/grub2.mk
+++ b/boot/grub2/grub2.mk
@@ -53,7 +53,7 @@  GRUB2_CONF_ENV = \
 	$(HOST_CONFIGURE_OPTS) \
 	CPP="$(HOSTCC) -E" \
 	TARGET_CC="$(TARGET_CC)" \
-	TARGET_CFLAGS="$(TARGET_CFLAGS)" \
+	TARGET_CFLAGS="$(TARGET_CFLAGS) -fno-stack-protector" \
 	TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \
 	TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
 	NM="$(TARGET_NM)" \