diff mbox

[1/2] wpa_supplicant: Clear ext_mgmt_frame_handling flag on P2P_FLUSH

Message ID 1503333432-15100-1-git-send-email-andrei.otcheretianski@intel.com
State Changes Requested
Headers show

Commit Message

Andrei Otcheretianski Aug. 21, 2017, 4:37 p.m. UTC 
This allows to use this flag on a dedicated P2P device interface,
which is needed to support MGMT_TX/RX on P2P device.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
---
 wpa_supplicant/ctrl_iface.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jouni Malinen Jan. 1, 2019, 3:03 p.m. UTC | #1 
On Mon, Aug 21, 2017 at 07:37:11PM +0300, Andrei Otcheretianski wrote:
> This allows to use this flag on a dedicated P2P device interface,
> which is needed to support MGMT_TX/RX on P2P device.

> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -6669,6 +6669,7 @@ static void p2p_ctrl_flush(struct wpa_supplicant *wpa_s)
>  {
>  	os_memset(wpa_s->p2p_auth_invite, 0, ETH_ALEN);
>  	wpa_s->force_long_sd = 0;
> +	wpa_s->ext_mgmt_frame_handling = 0;

This sounds strange.. wpa_s->ext_mgmt_frame_handling is already cleared
to 0 on FLUSH. Why would it need to be done on P2P_FLUSH as well?
ext_mgmt_frame_handling should not really have anything specific to do
with P2P.
diff mbox

Patch

diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
index 863dc99..6f91b83 100644
--- a/wpa_supplicant/ctrl_iface.c
+++ b/wpa_supplicant/ctrl_iface.c
@@ -6669,6 +6669,7 @@  static void p2p_ctrl_flush(struct wpa_supplicant *wpa_s)
 {
 	os_memset(wpa_s->p2p_auth_invite, 0, ETH_ALEN);
 	wpa_s->force_long_sd = 0;
+	wpa_s->ext_mgmt_frame_handling = 0;
 
 #ifdef CONFIG_TESTING_OPTIONS
 	os_free(wpa_s->get_pref_freq_list_override);