diff mbox

[U-Boot] net: fman: add support RGMII_TXID to memac

Message ID 1501827293-10686-1-git-send-email-madalin.bucur@nxp.com
State Accepted
Commit 3f8f1410b5d5d1fcbc28ea06700a9b601d736575
Delegated to: Joe Hershberger
Headers show

Commit Message

Madalin Bucur Aug. 4, 2017, 6:14 a.m. UTC
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/fm/memac.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Joe Hershberger Aug. 4, 2017, 3:57 p.m. UTC | #1
On Fri, Aug 4, 2017 at 1:14 AM, Madalin Bucur <madalin.bucur@nxp.com> wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
York Sun Aug. 4, 2017, 4:03 p.m. UTC | #2
On 08/03/2017 11:15 PM, Madalin Bucur wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
>   drivers/net/fm/memac.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c
> index 1b5779c..ea50ed3 100644
> --- a/drivers/net/fm/memac.c
> +++ b/drivers/net/fm/memac.c
> @@ -84,6 +84,7 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
>   		if_mode |= IF_MODE_GMII;
>   		break;
>   	case PHY_INTERFACE_MODE_RGMII:
> +	case PHY_INTERFACE_MODE_RGMII_TXID:
>   		if_mode |= (IF_MODE_GMII | IF_MODE_RG);
>   		break;
>   	case PHY_INTERFACE_MODE_RMII:
> @@ -106,7 +107,8 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
>   	if (type != PHY_INTERFACE_MODE_XGMII)
>   		if_mode |= IF_MODE_EN_AUTO;
>   
> -	if (type == PHY_INTERFACE_MODE_RGMII) {
> +	if (type == PHY_INTERFACE_MODE_RGMII ||
> +	    type == PHY_INTERFACE_MODE_RGMII_TXID) {
>   		if_mode &= ~IF_MODE_EN_AUTO;
>   		if_mode &= ~IF_MODE_SETSP_MASK;
>   		switch (speed) {
> 

Madalin,

This patch doesn't fix the RGMII port (FM1@DTSEC3) issue I found on 
LS1043ARDB.
Reverting 5a78a472f6660a72b9343a93791353ac879eeed0 makes this port working.

York
Joe Hershberger Aug. 14, 2017, 5:49 p.m. UTC | #3
Hi Madalin,

https://patchwork.ozlabs.org/patch/797657/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c
index 1b5779c..ea50ed3 100644
--- a/drivers/net/fm/memac.c
+++ b/drivers/net/fm/memac.c
@@ -84,6 +84,7 @@  static void memac_set_interface_mode(struct fsl_enet_mac *mac,
 		if_mode |= IF_MODE_GMII;
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_TXID:
 		if_mode |= (IF_MODE_GMII | IF_MODE_RG);
 		break;
 	case PHY_INTERFACE_MODE_RMII:
@@ -106,7 +107,8 @@  static void memac_set_interface_mode(struct fsl_enet_mac *mac,
 	if (type != PHY_INTERFACE_MODE_XGMII)
 		if_mode |= IF_MODE_EN_AUTO;
 
-	if (type == PHY_INTERFACE_MODE_RGMII) {
+	if (type == PHY_INTERFACE_MODE_RGMII ||
+	    type == PHY_INTERFACE_MODE_RGMII_TXID) {
 		if_mode &= ~IF_MODE_EN_AUTO;
 		if_mode &= ~IF_MODE_SETSP_MASK;
 		switch (speed) {