diff mbox

[ovs-dev,0/4] system-traffic: Add basic IPv6 underlay tunnel tests

Message ID CAPWQB7EPh5BmbsXpuUh3uEBXKQO9MkhW_z2zVNWnaFVvRyDN_Q@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Joe Stringer July 14, 2017, 6:18 p.m. UTC 
On 7 July 2017 at 11:32, Ben Pfaff <blp@ovn.org> wrote:
> On Wed, Jun 07, 2017 at 07:54:23PM -0400, Eric Garver wrote:
>> Currently there is no system-traffic coverage for tunnels with IPv6 underlays.
>> This series adds very basic ping tests for VXLANv6 and GENEVEv6.
>>
>> Note: GREv6 is not added by this series due to some incompatibilities between
>> OVS and Linux native ip6gretap. More info available in bugzilla [0].
>>
>> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1459605
>>
>> Eric Garver (4):
>>   system-common-macros: Add ip_addr_flags argument to ADD_VETH()
>>   system-common-macros: Add macros to create IPv6 tunnels
>>   system-traffic: datapath: Add vxlan6 test case.
>>   system-traffic: datapath: Add geneve6 test case.
>
> Joe, are you the right person to review these?

Slowly catching up on my backlog, sorry for the delay. Yes.

Eric, thanks for the series. For the first patch, I think that it'd be
nice to apply this for all IPv6 tests to speed them up. Given that we
assume control of the host for running these tests, I don't think
there's any situation where we actually want duplicate address
detection here. I looked to see if we could change the addresses in
the testsuite, for example to use link-local IPv6 addresses which I
think could avoid DAD, but if we did this then we would need to update
all of the pings and wgets and so on to specify a device; as it turns
out, even quite recent versions of wget do not parse the arguments
reliably to be able to do this. So, I think this would be more hassle
than it's worth. For now, we should stick with IPv6 ULAs (fc00:) for
the testsuite and just see if we can edge towards always disabling
DAD.

I intend to apply this series as-is shortly, with just the following
incremental to skip the geneve6 test when iproute can't configure it
properly:

ADD_BR([br-underlay])

Cheers,
Joe
diff mbox

Patch

diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 2c3b2f9880c8..5b4c515cb0c5 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -382,6 +382,7 @@  AT_CLEANUP

AT_SETUP([datapath - ping over geneve6 tunnel])
OVS_CHECK_GENEVE()
+AT_SKIP_IF([! ip link add foo type geneve help 2>&1 | grep zerocsum
>/dev/null])

OVS_TRAFFIC_VSWITCHD_START()