[ovs-dev,5/6] ovn.at: Use a correct operator in a test expression
diff mbox

Message ID 1500053986-38406-5-git-send-email-yamamoto@ovn.org
State Accepted
Delegated to: Ben Pfaff
Headers show

Commit Message

Takashi YAMAMOTO July 14, 2017, 5:39 p.m. UTC
== is a GNU extension.

Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
---
 tests/ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff July 14, 2017, 9:56 p.m. UTC | #1
On Sat, Jul 15, 2017 at 02:39:45AM +0900, YAMAMOTO Takashi wrote:
> == is a GNU extension.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>

I wish this didn't exist in the GNU version.  It's a useless extension.

Acked-by: Ben Pfaff <blp@ovn.org>
Takashi YAMAMOTO July 15, 2017, 1:51 p.m. UTC | #2
On Sat, Jul 15, 2017 at 6:56 AM, Ben Pfaff <blp@ovn.org> wrote:

> On Sat, Jul 15, 2017 at 02:39:45AM +0900, YAMAMOTO Takashi wrote:
> > == is a GNU extension.
> >
> > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
>
> I wish this didn't exist in the GNU version.  It's a useless extension.
>

i totally agree.


>
> Acked-by: Ben Pfaff <blp@ovn.org>
>

applied to master. thank you.

Patch
diff mbox

diff --git a/tests/ovn.at b/tests/ovn.at
index efcbd91..06edcaa 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -7459,7 +7459,7 @@  test_packet() {
     local packet=$(echo $dst$src | sed 's/://g')${eth}
     hv=`vif_to_hv $inport`
     # If hypervisor 0 (localport) use the defhv parameter
-    if test $hv == hv0; then
+    if test $hv = hv0; then
         hv=$defhv
     fi
     vif=vif$inport