[ovs-dev,3/6] pmd.at: Avoid using GNU sed extension
diff mbox

Message ID 1500053986-38406-3-git-send-email-yamamoto@ovn.org
State Accepted
Delegated to: Ben Pfaff
Headers show

Commit Message

Takashi YAMAMOTO July 14, 2017, 5:39 p.m. UTC
BRE alternative (\|) is an GNU sed extension. [1]
It isn't available in NetBSD sed.

[1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions
    regexp1\|regexp2
        Matches either regexp1 or regexp2. Use parentheses to use
        complex alternative regular expressions. The matching process
        tries each alternative in turn, from left to right, and the
        first one that succeeds is used. It is a GNU extension.

Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
---
 tests/pmd.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff July 14, 2017, 9:55 p.m. UTC | #1
On Sat, Jul 15, 2017 at 02:39:43AM +0900, YAMAMOTO Takashi wrote:
> BRE alternative (\|) is an GNU sed extension. [1]
> It isn't available in NetBSD sed.
> 
> [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions
>     regexp1\|regexp2
>         Matches either regexp1 or regexp2. Use parentheses to use
>         complex alternative regular expressions. The matching process
>         tries each alternative in turn, from left to right, and the
>         first one that succeeds is used. It is a GNU extension.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>

Acked-by: Ben Pfaff <blp@ovn.org>
Takashi YAMAMOTO July 15, 2017, 1:50 p.m. UTC | #2
On Sat, Jul 15, 2017 at 6:55 AM, Ben Pfaff <blp@ovn.org> wrote:

> On Sat, Jul 15, 2017 at 02:39:43AM +0900, YAMAMOTO Takashi wrote:
> > BRE alternative (\|) is an GNU sed extension. [1]
> > It isn't available in NetBSD sed.
> >
> > [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions
> >     regexp1\|regexp2
> >         Matches either regexp1 or regexp2. Use parentheses to use
> >         complex alternative regular expressions. The matching process
> >         tries each alternative in turn, from left to right, and the
> >         first one that succeeds is used. It is a GNU extension.
> >
> > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org>
>
> Acked-by: Ben Pfaff <blp@ovn.org>
>

applied to master. thank you.

Patch
diff mbox

diff --git a/tests/pmd.at b/tests/pmd.at
index d041dce..f95a016 100644
--- a/tests/pmd.at
+++ b/tests/pmd.at
@@ -53,7 +53,7 @@  m4_define([CHECK_PMD_THREADS_CREATED], [
 ])
 
 m4_define([SED_NUMA_CORE_PATTERN], ["s/\(numa_id \)[[0-9]]*\( core_id \)[[0-9]]*:/\1<cleared>\2<cleared>:/"])
-m4_define([SED_NUMA_CORE_QUEUE_PATTERN], ["s/\(numa_id \)[[0-9]]*\( core_id \)[[0-9]]*:/\1<cleared>\2<cleared>:/;s/\(queue-id: \)\(0 2 4 6\|1 3 5 7\)/\1<cleared>/"])
+m4_define([SED_NUMA_CORE_QUEUE_PATTERN], ["s/\(numa_id \)[[0-9]]*\( core_id \)[[0-9]]*:/\1<cleared>\2<cleared>:/;s/\(queue-id: \)0 2 4 6/\1<cleared>/;s/\(queue-id: \)1 3 5 7/\1<cleared>/"])
 m4_define([DUMMY_NUMA], [--dummy-numa="0,0,0,0"])
 
 AT_SETUP([PMD - creating a thread/add-port])