Message ID | 1499363142.7656.158.camel@redhat.com |
---|---|
State | New |
Headers | show |
On Thu, Jul 06, 2017 at 01:45:42PM -0400, David Malcolm wrote: > Given that the previous status quo of the selftests was to require the > C frontend, I committed the attached patch (as r250036), under the > "obvious" rule, retaining the ability to optionally run the selftests > within the C++ frontend. You should do something similar for how we make check etc.: CHECK_TARGETS = @check_languages@ check: $(CHECK_TARGETS) and then each Make-lang.in defining its check-<lang> goal. So similarly to that s-selftest-c++ should be in cp/Make-lang.in and based on the configured languages should include the s-selftest-<lang> dependencies. Jakub
Index: gcc/ChangeLog =================================================================== --- gcc/ChangeLog (revision 250035) +++ gcc/ChangeLog (revision 250036) @@ -1,3 +1,7 @@ +2017-07-06 David Malcolm <dmalcolm@redhat.com> + + * Makefile.in (selftest): Remove dependency on s-selftest-c++. + 2017-07-06 Jan Hubicka <hubicka@ucw.cz> * lto-wrapper.c (merge_and_complain): Do not merge Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in (revision 250035) +++ gcc/Makefile.in (revision 250036) @@ -1920,8 +1920,10 @@ # Use "s-selftest-FE" to ensure that we only run the selftests if the # driver, frontend, or selftest data change. .PHONY: selftest -selftest: s-selftest-c s-selftest-c++ +# By default, only run the selftests within the C frontend +selftest: s-selftest-c + # C selftests s-selftest-c: $(C_SELFTEST_DEPS) $(GCC_FOR_TARGET) $(C_SELFTEST_FLAGS)