diff mbox

[1/2] video: adp8860: move header file out of I2C realm

Message ID 20170521220953.2602-2-wsa@the-dreams.de
State Awaiting Upstream
Headers show

Commit Message

Wolfram Sang May 21, 2017, 10:09 p.m. UTC
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
 drivers/video/backlight/adp8860_bl.c           | 2 +-
 include/linux/{i2c => platform_data}/adp8860.h | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename include/linux/{i2c => platform_data}/adp8860.h (100%)

Comments

Bartlomiej Zolnierkiewicz May 29, 2017, 9:22 a.m. UTC | #1
On Monday, May 22, 2017 12:09:52 AM Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---
>  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>  drivers/video/backlight/adp8860_bl.c           | 2 +-
>  include/linux/{i2c => platform_data}/adp8860.h | 0
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename include/linux/{i2c => platform_data}/adp8860.h (100%)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daniel Thompson June 7, 2017, 10:57 a.m. UTC | #2
On 21/05/17 23:09, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

> ---
>   arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>   drivers/video/backlight/adp8860_bl.c           | 2 +-
>   include/linux/{i2c => platform_data}/adp8860.h | 0
>   3 files changed, 2 insertions(+), 2 deletions(-)
>   rename include/linux/{i2c => platform_data}/adp8860.h (100%)
> 
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 24985e658c19cd..7db90c72bd8ddc 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
>   #endif
>   
>   #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
>   static struct led_info adp8860_leds[] = {
>   	{
>   		.name = "adp8860-led7",
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 510e559c060e59..e7315bf14d6015 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -18,7 +18,7 @@
>   #include <linux/slab.h>
>   #include <linux/workqueue.h>
>   
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
>   #define ADP8860_EXT_FEATURES
>   #define ADP8860_USE_LEDS
>   
> diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> similarity index 100%
> rename from include/linux/i2c/adp8860.h
> rename to include/linux/platform_data/adp8860.h
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hennerich, Michael June 7, 2017, 12:10 p.m. UTC | #3
On 07.06.2017 12:57, Daniel Thompson wrote:
> On 21/05/17 23:09, Wolfram Sang wrote:
>> include/linux/i2c is not for client devices. Move the header file to a
>> more appropriate location.
>>
>> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> 
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> 
>> ---
>>   arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>>   drivers/video/backlight/adp8860_bl.c           | 2 +-
>>   include/linux/{i2c => platform_data}/adp8860.h | 0
>>   3 files changed, 2 insertions(+), 2 deletions(-)
>>   rename include/linux/{i2c => platform_data}/adp8860.h (100%)
>>
>> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c 
>> b/arch/blackfin/mach-bf537/boards/stamp.c
>> index 24985e658c19cd..7db90c72bd8ddc 100644
>> --- a/arch/blackfin/mach-bf537/boards/stamp.c
>> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
>> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data 
>> adp8870_pdata = {
>>   #endif
>>   #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>>   static struct led_info adp8860_leds[] = {
>>       {
>>           .name = "adp8860-led7",
>> diff --git a/drivers/video/backlight/adp8860_bl.c 
>> b/drivers/video/backlight/adp8860_bl.c
>> index 510e559c060e59..e7315bf14d6015 100644
>> --- a/drivers/video/backlight/adp8860_bl.c
>> +++ b/drivers/video/backlight/adp8860_bl.c
>> @@ -18,7 +18,7 @@
>>   #include <linux/slab.h>
>>   #include <linux/workqueue.h>
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>>   #define ADP8860_EXT_FEATURES
>>   #define ADP8860_USE_LEDS
>> diff --git a/include/linux/i2c/adp8860.h 
>> b/include/linux/platform_data/adp8860.h
>> similarity index 100%
>> rename from include/linux/i2c/adp8860.h
>> rename to include/linux/platform_data/adp8860.h
>>
> 
>
Lee Jones June 9, 2017, 7:43 a.m. UTC | #4
On Mon, 22 May 2017, Wolfram Sang wrote:

> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>  drivers/video/backlight/adp8860_bl.c           | 2 +-
>  include/linux/{i2c => platform_data}/adp8860.h | 0
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename include/linux/{i2c => platform_data}/adp8860.h (100%)

Applied, thanks.

> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 24985e658c19cd..7db90c72bd8ddc 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
>  #endif
>  
>  #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
>  static struct led_info adp8860_leds[] = {
>  	{
>  		.name = "adp8860-led7",
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 510e559c060e59..e7315bf14d6015 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -18,7 +18,7 @@
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
>  
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
>  #define ADP8860_EXT_FEATURES
>  #define ADP8860_USE_LEDS
>  
> diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> similarity index 100%
> rename from include/linux/i2c/adp8860.h
> rename to include/linux/platform_data/adp8860.h
Lee Jones June 9, 2017, 7:49 a.m. UTC | #5
On Fri, 09 Jun 2017, Lee Jones wrote:

> On Mon, 22 May 2017, Wolfram Sang wrote:
> 
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> > 
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> >  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
> >  drivers/video/backlight/adp8860_bl.c           | 2 +-
> >  include/linux/{i2c => platform_data}/adp8860.h | 0
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> >  rename include/linux/{i2c => platform_data}/adp8860.h (100%)
> 
> Applied, thanks.

Scrap that.  I can't actually apply these without Steven's Ack.

> > diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> > index 24985e658c19cd..7db90c72bd8ddc 100644
> > --- a/arch/blackfin/mach-bf537/boards/stamp.c
> > +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> > @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
> >  #endif
> >  
> >  #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> >  static struct led_info adp8860_leds[] = {
> >  	{
> >  		.name = "adp8860-led7",
> > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> > index 510e559c060e59..e7315bf14d6015 100644
> > --- a/drivers/video/backlight/adp8860_bl.c
> > +++ b/drivers/video/backlight/adp8860_bl.c
> > @@ -18,7 +18,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/workqueue.h>
> >  
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> >  #define ADP8860_EXT_FEATURES
> >  #define ADP8860_USE_LEDS
> >  
> > diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> > similarity index 100%
> > rename from include/linux/i2c/adp8860.h
> > rename to include/linux/platform_data/adp8860.h
>
diff mbox

Patch

diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
index 24985e658c19cd..7db90c72bd8ddc 100644
--- a/arch/blackfin/mach-bf537/boards/stamp.c
+++ b/arch/blackfin/mach-bf537/boards/stamp.c
@@ -2047,7 +2047,7 @@  static struct adp8870_backlight_platform_data adp8870_pdata = {
 #endif
 
 #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
-#include <linux/i2c/adp8860.h>
+#include <linux/platform_data/adp8860.h>
 static struct led_info adp8860_leds[] = {
 	{
 		.name = "adp8860-led7",
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 510e559c060e59..e7315bf14d6015 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -18,7 +18,7 @@ 
 #include <linux/slab.h>
 #include <linux/workqueue.h>
 
-#include <linux/i2c/adp8860.h>
+#include <linux/platform_data/adp8860.h>
 #define ADP8860_EXT_FEATURES
 #define ADP8860_USE_LEDS
 
diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
similarity index 100%
rename from include/linux/i2c/adp8860.h
rename to include/linux/platform_data/adp8860.h