diff mbox

Don't assume __secure_getenv is available

Message ID CAO9iq9GN3xyT0pDubNKmMUH8jg7t4aXzeHWkO2JANtBTUhvn7A@mail.gmail.com
State New
Headers show

Commit Message

Janne Blomqvist April 27, 2017, 6:55 p.m. UTC 
On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist
<blomqvist.janne@gmail.com> wrote:
[snip]

And on top of that patch this simple typo fix:

Comments

Li, Pan2 via Gcc-patches May 8, 2017, 6:37 a.m. UTC | #1 
PING

On Thu, Apr 27, 2017 at 9:55 PM, Janne Blomqvist
<blomqvist.janne@gmail.com> wrote:
> On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist
> <blomqvist.janne@gmail.com> wrote:
> [snip]
>
> And on top of that patch this simple typo fix:
>
> diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c
> index 969dcdf..f488e87 100644
> --- a/libgfortran/runtime/environ.c
> +++ b/libgfortran/runtime/environ.c
> @@ -46,7 +46,7 @@ static char* weak_secure_getenv (const char*)
>  char *
>  secure_getenv (const char *name)
>  {
> -#if SUPPORTS_WEAKREF && defined(HAVE__SECURE_GETENV)
> +#if SUPPORTS_WEAKREF && defined(HAVE___SECURE_GETENV)
>    if (weak_secure_getenv)
>      return weak_secure_getenv (name);
>  #endif
>
>
>
> --
> Janne Blomqvist
Jerry DeLisle May 8, 2017, 5:33 p.m. UTC | #2 
On 05/07/2017 11:37 PM, Janne Blomqvist via fortran wrote:
> PING
> 
> On Thu, Apr 27, 2017 at 9:55 PM, Janne Blomqvist
> <blomqvist.janne@gmail.com> wrote:
>> On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist
>> <blomqvist.janne@gmail.com> wrote:
>> [snip]
>>
>> And on top of that patch this simple typo fix:
>>
>> diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c
>> index 969dcdf..f488e87 100644
>> --- a/libgfortran/runtime/environ.c
>> +++ b/libgfortran/runtime/environ.c
>> @@ -46,7 +46,7 @@ static char* weak_secure_getenv (const char*)
>>  char *
>>  secure_getenv (const char *name)
>>  {
>> -#if SUPPORTS_WEAKREF && defined(HAVE__SECURE_GETENV)
>> +#if SUPPORTS_WEAKREF && defined(HAVE___SECURE_GETENV)
>>    if (weak_secure_getenv)
>>      return weak_secure_getenv (name);
>>  #endif
>>
>>
>>
>> --
>> Janne Blomqvist
> 
> 
> 

Looks Ok to me. I thought you might be waiting for Jakub to reply.

Thanks,

Jerry
diff mbox

Patch

diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c
index 969dcdf..f488e87 100644
--- a/libgfortran/runtime/environ.c
+++ b/libgfortran/runtime/environ.c
@@ -46,7 +46,7 @@  static char* weak_secure_getenv (const char*)
 char *
 secure_getenv (const char *name)
 {
-#if SUPPORTS_WEAKREF && defined(HAVE__SECURE_GETENV)
+#if SUPPORTS_WEAKREF && defined(HAVE___SECURE_GETENV)
   if (weak_secure_getenv)
     return weak_secure_getenv (name);
 #endif