| Message ID | 1493181705-18531-1-git-send-email-tnhuynh@apm.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote: > From: Tin Huynh <tnhuynh@apm.com> > > Certain I2C slave drivers, such as the pca95xx, require > only I2C operations instead of SMBus extensions. > This patch adds I2C_FUNC_I2C functionally to support those drivers. No Signed-off, please run checkpatch on your patches! > - return I2C_FUNC_SMBUS_BYTE | > + return I2C_FUNC_I2C | > + I2C_FUNC_SMBUS_BYTE | Does this really work? You don't have a master_xfer function, so I think it cannot work. You don't seem to have I2C_FUNC_I2C support in your driver. > I2C_FUNC_SMBUS_BYTE_DATA | > I2C_FUNC_SMBUS_WORD_DATA | > I2C_FUNC_SMBUS_BLOCK_DATA | > -- > 1.7.1 >
On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote: > From: Tin Huynh <tnhuynh@apm.com> > > Certain I2C slave drivers, such as the pca95xx, require > only I2C operations instead of SMBus extensions. > This patch adds I2C_FUNC_I2C functionally to support those drivers. Again, no Signed-off. I can't apply it without one. lso, please add your full name to the mail header.
On Tue, May 16, 2017 at 11:39:08PM +0200, Wolfram Sang wrote: > On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote: > > From: Tin Huynh <tnhuynh@apm.com> > > > > Certain I2C slave drivers, such as the pca95xx, require > > only I2C operations instead of SMBus extensions. > > This patch adds I2C_FUNC_I2C functionally to support those drivers. > > Again, no Signed-off. I can't apply it without one. lso, please add your > full name to the mail header. Wrong mail, should have been replied to the other patch, sorry!
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c index dbe7e44..439357c 100644 --- a/drivers/i2c/busses/i2c-xgene-slimpro.c +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c @@ -365,7 +365,8 @@ static int xgene_slimpro_i2c_xfer(struct i2c_adapter *adap, u16 addr, */ static u32 xgene_slimpro_i2c_func(struct i2c_adapter *adapter) { - return I2C_FUNC_SMBUS_BYTE | + return I2C_FUNC_I2C | + I2C_FUNC_SMBUS_BYTE | I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA | I2C_FUNC_SMBUS_BLOCK_DATA |
From: Tin Huynh <tnhuynh@apm.com> Certain I2C slave drivers, such as the pca95xx, require only I2C operations instead of SMBus extensions. This patch adds I2C_FUNC_I2C functionally to support those drivers. --- drivers/i2c/busses/i2c-xgene-slimpro.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)