| Message ID | 20170410082614.5636-1-vigneshr@ti.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
On 4/10/2017 1:56 PM, Vignesh R wrote: > It seems few config options are missing in the current > am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x > EVM. Fix this by adding required configs. > > Signed-off-by: Vignesh R <vigneshr@ti.com> > --- > configs/am335x_evm_usbspl_defconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig > index a79470e88685..0a32d41eae67 100644 > --- a/configs/am335x_evm_usbspl_defconfig > +++ b/configs/am335x_evm_usbspl_defconfig Any thing that is blocking to use am335x_evm_defconfig for usb eth boot mode? Eventually we will have make single defconfig for all boot modes. Thanks and regards, Lokesh > @@ -44,3 +44,7 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" > CONFIG_G_DNL_VENDOR_NUM=0x0451 > CONFIG_G_DNL_PRODUCT_NUM=0xd022 > CONFIG_OF_LIBFDT=y > +CONFIG_SPL_ETH_SUPPORT=y > +CONFIG_SPL_USB_GADGET_SUPPORT=y > +CONFIG_SPL_USBETH_SUPPORT=y > +CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" >
On Monday 10 April 2017 06:28 PM, Lokesh Vutla wrote: > > > On 4/10/2017 1:56 PM, Vignesh R wrote: >> It seems few config options are missing in the current >> am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x >> EVM. Fix this by adding required configs. >> >> Signed-off-by: Vignesh R <vigneshr@ti.com> >> --- >> configs/am335x_evm_usbspl_defconfig | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig >> index a79470e88685..0a32d41eae67 100644 >> --- a/configs/am335x_evm_usbspl_defconfig >> +++ b/configs/am335x_evm_usbspl_defconfig > > Any thing that is blocking to use am335x_evm_defconfig for usb eth boot > mode? Yes, I guess first thing needed is would be SPL_DM support as AFAIK, DM_ETH forces to use DM in both SPL and U-Boot. > Eventually we will have make single defconfig for all boot modes. I guess, this should be possible once SPL_DM support is added. > Thanks and regards, > Lokesh > >> @@ -44,3 +44,7 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" >> CONFIG_G_DNL_VENDOR_NUM=0x0451 >> CONFIG_G_DNL_PRODUCT_NUM=0xd022 >> CONFIG_OF_LIBFDT=y >> +CONFIG_SPL_ETH_SUPPORT=y >> +CONFIG_SPL_USB_GADGET_SUPPORT=y >> +CONFIG_SPL_USBETH_SUPPORT=y >> +CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" >>
On Tuesday 11 April 2017 10:30 AM, Vignesh R wrote: > > > On Monday 10 April 2017 06:28 PM, Lokesh Vutla wrote: >> >> >> On 4/10/2017 1:56 PM, Vignesh R wrote: >>> It seems few config options are missing in the current >>> am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x >>> EVM. Fix this by adding required configs. >>> >>> Signed-off-by: Vignesh R <vigneshr@ti.com> >>> --- >>> configs/am335x_evm_usbspl_defconfig | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig >>> index a79470e88685..0a32d41eae67 100644 >>> --- a/configs/am335x_evm_usbspl_defconfig >>> +++ b/configs/am335x_evm_usbspl_defconfig >> >> Any thing that is blocking to use am335x_evm_defconfig for usb eth boot >> mode? > > Yes, I guess first thing needed is would be SPL_DM support as AFAIK, > DM_ETH forces to use DM in both SPL and U-Boot. okay. am335x has its own problems enabling SPL_DM on which I am working on. Can you check am43xx which has SPL_DM enabled?(I understand there is no am43xx_evm_usbspl_defconfig but wanted to know what is blocking to use am43xx_evm_defconfig for usb_eth mode?) > >> Eventually we will have make single defconfig for all boot modes. > > I guess, this should be possible once SPL_DM support is added. Thanks. Regards, Lokesh > >> Thanks and regards, >> Lokesh >> >>> @@ -44,3 +44,7 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" >>> CONFIG_G_DNL_VENDOR_NUM=0x0451 >>> CONFIG_G_DNL_PRODUCT_NUM=0xd022 >>> CONFIG_OF_LIBFDT=y >>> +CONFIG_SPL_ETH_SUPPORT=y >>> +CONFIG_SPL_USB_GADGET_SUPPORT=y >>> +CONFIG_SPL_USBETH_SUPPORT=y >>> +CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" >>> >
On Tuesday 11 April 2017 11:25 AM, Lokesh Vutla wrote: > > > On Tuesday 11 April 2017 10:30 AM, Vignesh R wrote: >> >> >> On Monday 10 April 2017 06:28 PM, Lokesh Vutla wrote: >>> >>> >>> On 4/10/2017 1:56 PM, Vignesh R wrote: >>>> It seems few config options are missing in the current >>>> am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x >>>> EVM. Fix this by adding required configs. >>>> >>>> Signed-off-by: Vignesh R <vigneshr@ti.com> >>>> --- >>>> configs/am335x_evm_usbspl_defconfig | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig >>>> index a79470e88685..0a32d41eae67 100644 >>>> --- a/configs/am335x_evm_usbspl_defconfig >>>> +++ b/configs/am335x_evm_usbspl_defconfig >>> >>> Any thing that is blocking to use am335x_evm_defconfig for usb eth boot >>> mode? >> >> Yes, I guess first thing needed is would be SPL_DM support as AFAIK, >> DM_ETH forces to use DM in both SPL and U-Boot. > > okay. am335x has its own problems enabling SPL_DM on which I am working > on. Can you check am43xx which has SPL_DM enabled?(I understand there is > no am43xx_evm_usbspl_defconfig but wanted to know what is blocking to > use am43xx_evm_defconfig for usb_eth mode?) > dwc3 usb peripheral needs be converted to DM as first step. Need to revisit: http://lists.denx.de/pipermail/u-boot/2016-March/250115.html This is something that I have in my list of TODOs.
Lokesh, On Monday 10 April 2017 01:56 PM, Vignesh R wrote: > It seems few config options are missing in the current > am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x > EVM. Fix this by adding required configs. > > Signed-off-by: Vignesh R <vigneshr@ti.com> > --- Could you ack this patch, its still relevant to get USB RNDIS to work. > configs/am335x_evm_usbspl_defconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig > index a79470e88685..0a32d41eae67 100644 > --- a/configs/am335x_evm_usbspl_defconfig > +++ b/configs/am335x_evm_usbspl_defconfig > @@ -44,3 +44,7 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" > CONFIG_G_DNL_VENDOR_NUM=0x0451 > CONFIG_G_DNL_PRODUCT_NUM=0xd022 > CONFIG_OF_LIBFDT=y > +CONFIG_SPL_ETH_SUPPORT=y > +CONFIG_SPL_USB_GADGET_SUPPORT=y > +CONFIG_SPL_USBETH_SUPPORT=y > +CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" >
diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig index a79470e88685..0a32d41eae67 100644 --- a/configs/am335x_evm_usbspl_defconfig +++ b/configs/am335x_evm_usbspl_defconfig @@ -44,3 +44,7 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y +CONFIG_SPL_ETH_SUPPORT=y +CONFIG_SPL_USB_GADGET_SUPPORT=y +CONFIG_SPL_USBETH_SUPPORT=y +CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL"
It seems few config options are missing in the current am335x_evm_usbspl_defconfig causing USB RNDIS boot to fail on AM335x EVM. Fix this by adding required configs. Signed-off-by: Vignesh R <vigneshr@ti.com> --- configs/am335x_evm_usbspl_defconfig | 4 ++++ 1 file changed, 4 insertions(+)