| Message ID | 20170326191114.3756-1-alexander@alemayhu.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Sun, 26 Mar 2017 21:11:14 +0200 Alexander Alemayhu <alexander@alemayhu.com> wrote: > While generating PDFs from the man pages, I saw the warning below from > several files. Compared the tc-matchall.8 with bridge.8 and used .RI > instead of .R. It should have no effect on the man page rendering. > > `R' is a string (producing the registered sign), not a macro. > > Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> Applied
On Sun, Mar 26, 2017 at 09:11:14PM +0200, Alexander Alemayhu wrote: > While generating PDFs from the man pages, I saw the warning below from > several files. Compared the tc-matchall.8 with bridge.8 and used .RI > instead of .R. It should have no effect on the man page rendering. > > `R' is a string (producing the registered sign), not a macro. > > Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> I know this has been applied already, but let me get this straight: People using '.R' try to force "normal" font, like for every second parameter to '.IR' but in fact they could just leave the macro away since lines starting without any macro will get normal font settings anyway. With this in mind, I see better solutions for the changes in this patch: [...] > @@ -20,7 +20,7 @@ flower \- flow based traffic control filter > .B indev > .IR ifname " | " > .BR skip_sw " | " skip_hw > -.R " | { " > +.RI " | { " Just merge this into previous line: | .BR skip_sw " | " skip_hw " | {" Note the missing space at the end, as that comes for free anyway. :) [...] > @@ -13,7 +13,7 @@ IFE - encapsulate/decapsulate metadata > .IR SMAC " ] " > .RB "[ " type > .IR TYPE " ] " > -.R "[ " > +.RI "[ " Same here: | .IR TYPE " ] [" [...] > @@ -7,7 +7,7 @@ matchall \- traffic control filter that matches every packet > .ti -8 > .BR tc " " filter " ... " matchall " [ " > .BR skip_sw " | " skip_hw > -.R " ] [ " > +.RI " ] [ " And here as well: | .BR skip_sw " | " skip_hw " ] [" Cheers, Phil
On Wed, Apr 05, 2017 at 04:56:23PM +0200, Phil Sutter wrote: > > People using '.R' try to force "normal" font, like for every second > parameter to '.IR' but in fact they could just leave the macro away > since lines starting without any macro will get normal font settings > anyway. > I will keep your comment in mind for next time. Thanks.
diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 index fc5bac503324..ba290657c224 100644 --- a/man/man8/tc-flower.8 +++ b/man/man8/tc-flower.8 @@ -20,7 +20,7 @@ flower \- flow based traffic control filter .B indev .IR ifname " | " .BR skip_sw " | " skip_hw -.R " | { " +.RI " | { " .BR dst_mac " | " src_mac " } " .IR MASKED_LLADDR " | " .B vlan_id diff --git a/man/man8/tc-ife.8 b/man/man8/tc-ife.8 index dae8b9be9bcb..a8f1f287d150 100644 --- a/man/man8/tc-ife.8 +++ b/man/man8/tc-ife.8 @@ -13,7 +13,7 @@ IFE - encapsulate/decapsulate metadata .IR SMAC " ] " .RB "[ " type .IR TYPE " ] " -.R "[ " +.RI "[ " .IR CONTROL " ] " .RB "[ " index .IR INDEX " ] " diff --git a/man/man8/tc-matchall.8 b/man/man8/tc-matchall.8 index 53b2194e023a..e3cddb1f1ca5 100644 --- a/man/man8/tc-matchall.8 +++ b/man/man8/tc-matchall.8 @@ -7,7 +7,7 @@ matchall \- traffic control filter that matches every packet .ti -8 .BR tc " " filter " ... " matchall " [ " .BR skip_sw " | " skip_hw -.R " ] [ " +.RI " ] [ " .B action .IR ACTION_SPEC " ] [ " .B classid
While generating PDFs from the man pages, I saw the warning below from several files. Compared the tc-matchall.8 with bridge.8 and used .RI instead of .R. It should have no effect on the man page rendering. `R' is a string (producing the registered sign), not a macro. Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> --- man/man8/tc-flower.8 | 2 +- man/man8/tc-ife.8 | 2 +- man/man8/tc-matchall.8 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)