| Message ID | A614194ED15B4844BC4C9FB7F21FCD927045F682@HHMAIL01.hh.imgtec.org |
|---|---|
| State | New |
| Headers | show |
Toma Tabacu <Toma.Tabacu@imgtec.com> writes: > The pic-3,4.c and pie-3,4.c tests are failing for some configurations of > mips*-*-linux-*. > > This is because PIC is always on for MIPS Linux by default, except when the > compiler is built with --with-mips-plt, in which case PIC is on by default only > for the n64 ABI, because in this case -mplt "has no effect without '-msym32'", > to quote the documentation, so -mplt is not passed by default. > > Richard Sandiford also talked about this in the summary of a patch which was > skipping a test for mips*-*-linux-* because of PIC: > https://gcc.gnu.org/ml/gcc-patches/2009-01/msg00801.html > > Therefore, I think the most reasonable solution would be to just skip these > tests for mips*-*-linux-*. The patch below does so. > > Tested with mips-mti-linux-gnu. > > Catherine, Matthew what do you think ? Given the acceptance that MIPS PIC behaviour is semi-unique then checking MIPS complies with the rules around pre-processor behaviour doesn't add much value. I'm happy to skip these tests on the basis that software can't make the same assumptions about MIPS and __PIC__ as other architectures do. OK to commit. Thanks, Matthew
> From: Matthew Fortune > > Given the acceptance that MIPS PIC behaviour is semi-unique then checking > MIPS > complies with the rules around pre-processor behaviour doesn't add much > value. > I'm happy to skip these tests on the basis that software can't make the same > assumptions about MIPS and __PIC__ as other architectures do. > > OK to commit. > > Thanks, > Matthew Committed as r246533. Thanks, Toma
diff --git a/gcc/testsuite/gcc.dg/pic-3.c b/gcc/testsuite/gcc.dg/pic-3.c index 23ce999..c56f06f 100644 --- a/gcc/testsuite/gcc.dg/pic-3.c +++ b/gcc/testsuite/gcc.dg/pic-3.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* } } } } */ +/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* mips*-*-linux-* } } } } */ /* { dg-options "-fno-pic" } */ #ifdef __PIC__ diff --git a/gcc/testsuite/gcc.dg/pic-4.c b/gcc/testsuite/gcc.dg/pic-4.c index 8e14714..2afdd99 100644 --- a/gcc/testsuite/gcc.dg/pic-4.c +++ b/gcc/testsuite/gcc.dg/pic-4.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* } } } } */ +/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* mips*-*-linux-* } } } } */ /* { dg-options "-fno-PIC" } */ #ifdef __PIC__ diff --git a/gcc/testsuite/gcc.dg/pie-3.c b/gcc/testsuite/gcc.dg/pie-3.c index a7201c0..5577437 100644 --- a/gcc/testsuite/gcc.dg/pie-3.c +++ b/gcc/testsuite/gcc.dg/pie-3.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* } } } } */ +/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* mips*-*-linux-* } } } } */ /* { dg-options "-fno-pie" } */ #ifdef __PIC__ diff --git a/gcc/testsuite/gcc.dg/pie-4.c b/gcc/testsuite/gcc.dg/pie-4.c index b24eb8c..4134676 100644 --- a/gcc/testsuite/gcc.dg/pie-4.c +++ b/gcc/testsuite/gcc.dg/pie-4.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* } } } } */ +/* { dg-do compile { target { ! { *-*-darwin* hppa*64*-*-* mips*-*-linux-* } } } } */ /* { dg-options "-fno-PIE" } */ #ifdef __PIC__