diff mbox

[4/5] tree-inline: implement SIMT privatization, part 3

Message ID alpine.LNX.2.20.13.1703231910350.30883@monopod.intra.ispras.ru
State New
Headers show

Commit Message

Alexander Monakov March 23, 2017, 4:15 p.m. UTC 
On Thu, 23 Mar 2017, Jakub Jelinek wrote:
> > Sorry for missing the IR stability issue.  This code relies on dst_simt_vars
> > being a set and thus having no duplicate entries (so the implicit lookup when
> > adding an element is needed).
> > 
> > However, I think I was overly cautious: looking again, I think we can't enter
> > copy_decl_for_dup_finish twice with the same 'copy' VAR_DECL.  Changing it to a
> > vec should be fine then?
> 
> Yeah, callers of copy_decl* should look the orig var in the decl map first,
> plus if you look at all copy_decl_for_dup_finish callers, all of them first
> create a new tree (usually copy_node) and then pass it as copy to
> copy_decl_for_dup_finish, so you'll never get the same copy in there.
> 
> So, please change it into a vector.

Thanks — here's the updated patch.  I've also noticed there's no need to rebuild
the existing SIMT_ENTER statement if we didn't add any new privatized variables.

	* tree-inline.h (struct copy_body_data): New field dst_simt_vars.
        * tree-inline.c (expand_call_inline): Handle SIMT privatization.
        (copy_decl_for_dup_finish): Ditto.
---
 gcc/tree-inline.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++------
 gcc/tree-inline.h |  4 ++++
 2 files changed, 62 insertions(+), 7 deletions(-)

Comments

Jakub Jelinek March 23, 2017, 4:23 p.m. UTC | #1 
On Thu, Mar 23, 2017 at 07:15:52PM +0300, Alexander Monakov wrote:
> 	* tree-inline.h (struct copy_body_data): New field dst_simt_vars.
>         * tree-inline.c (expand_call_inline): Handle SIMT privatization.
>         (copy_decl_for_dup_finish): Ditto.
> ---
>  gcc/tree-inline.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++------
>  gcc/tree-inline.h |  4 ++++
>  2 files changed, 62 insertions(+), 7 deletions(-)
> 
> @@ -4588,15 +4593,26 @@ expand_call_inline (basic_block bb, gimple *stmt, copy_body_data *id)
>    id->src_cfun = DECL_STRUCT_FUNCTION (fn);
>    id->call_stmt = call_stmt;
>  
> +  /* When inlining into an OpenMP SIMD-on-SIMT loop, arrange for new automatic
> +     variables to be added to IFN_GOMP_SIMT_ENTER argument list.  */
> +  dst_cfun = DECL_STRUCT_FUNCTION (id->dst_fn);
> +  if (!(dst_cfun->curr_properties & PROP_gimple_lomp_dev)
> +      && (simduid = bb->loop_father->simduid) != NULL_TREE
> +      && (simduid = ssa_default_def (dst_cfun, simduid)) != NULL_TREE
> +      && single_imm_use (simduid, &use, &simtenter_stmt)
> +      && is_gimple_call (simtenter_stmt)
> +      && gimple_call_internal_p (simtenter_stmt, IFN_GOMP_SIMT_ENTER))
> +    {
> +      simtvars_st = id->dst_simt_vars;
> +      vec_alloc (id->dst_simt_vars, 0);
> +    }

One more thing.  If the above if condition is false, you keep
id->dst_simt_vars what it was (which means simtvars_st is NULL).
If it was non-NULL already, then:

> @@ -4730,6 +4746,31 @@ expand_call_inline (basic_block bb, gimple *stmt, copy_body_data *id)
>    if (cfun->gimple_df)
>      pt_solution_reset (&cfun->gimple_df->escaped);
>  
> +  /* Add new automatic variables to IFN_GOMP_SIMT_ENTER arguments.  */
> +  if (id->dst_simt_vars)
> +    {

This will be true.

> +      if (id->dst_simt_vars->length () > 0)
> +	{
> +	  size_t nargs = gimple_call_num_args (simtenter_stmt);
> +	  vec<tree> *vars = id->dst_simt_vars;
> +	  auto_vec<tree> newargs (nargs + vars->length ());
> +	  for (size_t i = 0; i < nargs; i++)
> +	    newargs.quick_push (gimple_call_arg (simtenter_stmt, i));
> +	  for (tree *pvar = vars->begin (); pvar != vars->end (); pvar++)
> +	    {
> +	      tree ptrtype = build_pointer_type (TREE_TYPE (*pvar));
> +	      newargs.quick_push (build1 (ADDR_EXPR, ptrtype, *pvar));
> +	    }
> +	  gcall *g
> +	    = gimple_build_call_internal_vec (IFN_GOMP_SIMT_ENTER, newargs);
> +	  gimple_call_set_lhs (g, gimple_call_lhs (simtenter_stmt));
> +	  gimple_stmt_iterator gsi = gsi_for_stmt (simtenter_stmt);
> +	  gsi_replace (&gsi, g, false);
> +	}

And you handle dst_simt_vars from some other invocation.

> +      vec_free (id->dst_simt_vars);
> +      id->dst_simt_vars = simtvars_st;

And then clear it.  That doesn't look like the right thing.

So either you need some bool variable whether you've actually allocated
the vector in the current expand_call_inline and use that instead of
if (id->dst_simt_vars), or maybe you should clear id->dst_simt_vars
otherwise and save/restore it around unconditionally.

	Jakub
diff mbox

Patch

diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c
index 6b6d489..a84e569 100644
--- a/gcc/tree-inline.c
+++ b/gcc/tree-inline.c
@@ -4385,6 +4385,11 @@  expand_call_inline (basic_block bb, gimple *stmt, copy_body_data *id)
   gcall *call_stmt;
   unsigned int i;
   unsigned int prop_mask, src_properties;
+  struct function *dst_cfun;
+  tree simduid;
+  use_operand_p use;
+  gimple *simtenter_stmt = NULL;
+  vec<tree> *simtvars_st = NULL;
 
   /* The gimplifier uses input_location in too many places, such as
      internal_get_tmp_var ().  */
@@ -4588,15 +4593,26 @@  expand_call_inline (basic_block bb, gimple *stmt, copy_body_data *id)
   id->src_cfun = DECL_STRUCT_FUNCTION (fn);
   id->call_stmt = call_stmt;
 
+  /* When inlining into an OpenMP SIMD-on-SIMT loop, arrange for new automatic
+     variables to be added to IFN_GOMP_SIMT_ENTER argument list.  */
+  dst_cfun = DECL_STRUCT_FUNCTION (id->dst_fn);
+  if (!(dst_cfun->curr_properties & PROP_gimple_lomp_dev)
+      && (simduid = bb->loop_father->simduid) != NULL_TREE
+      && (simduid = ssa_default_def (dst_cfun, simduid)) != NULL_TREE
+      && single_imm_use (simduid, &use, &simtenter_stmt)
+      && is_gimple_call (simtenter_stmt)
+      && gimple_call_internal_p (simtenter_stmt, IFN_GOMP_SIMT_ENTER))
+    {
+      simtvars_st = id->dst_simt_vars;
+      vec_alloc (id->dst_simt_vars, 0);
+    }
+
   /* If the src function contains an IFN_VA_ARG, then so will the dst
      function after inlining.  Likewise for IFN_GOMP_USE_SIMT.  */
   prop_mask = PROP_gimple_lva | PROP_gimple_lomp_dev;
   src_properties = id->src_cfun->curr_properties & prop_mask;
   if (src_properties != prop_mask)
-    {
-      struct function *dst_cfun = DECL_STRUCT_FUNCTION (id->dst_fn);
-      dst_cfun->curr_properties &= src_properties | ~prop_mask;
-    }
+    dst_cfun->curr_properties &= src_properties | ~prop_mask;
 
   gcc_assert (!id->src_cfun->after_inlining);
 
@@ -4730,6 +4746,31 @@  expand_call_inline (basic_block bb, gimple *stmt, copy_body_data *id)
   if (cfun->gimple_df)
     pt_solution_reset (&cfun->gimple_df->escaped);
 
+  /* Add new automatic variables to IFN_GOMP_SIMT_ENTER arguments.  */
+  if (id->dst_simt_vars)
+    {
+      if (id->dst_simt_vars->length () > 0)
+	{
+	  size_t nargs = gimple_call_num_args (simtenter_stmt);
+	  vec<tree> *vars = id->dst_simt_vars;
+	  auto_vec<tree> newargs (nargs + vars->length ());
+	  for (size_t i = 0; i < nargs; i++)
+	    newargs.quick_push (gimple_call_arg (simtenter_stmt, i));
+	  for (tree *pvar = vars->begin (); pvar != vars->end (); pvar++)
+	    {
+	      tree ptrtype = build_pointer_type (TREE_TYPE (*pvar));
+	      newargs.quick_push (build1 (ADDR_EXPR, ptrtype, *pvar));
+	    }
+	  gcall *g
+	    = gimple_build_call_internal_vec (IFN_GOMP_SIMT_ENTER, newargs);
+	  gimple_call_set_lhs (g, gimple_call_lhs (simtenter_stmt));
+	  gimple_stmt_iterator gsi = gsi_for_stmt (simtenter_stmt);
+	  gsi_replace (&gsi, g, false);
+	}
+      vec_free (id->dst_simt_vars);
+      id->dst_simt_vars = simtvars_st;
+    }
+
   /* Clean up.  */
   if (id->debug_map)
     {
@@ -5453,9 +5494,19 @@  copy_decl_for_dup_finish (copy_body_data *id, tree decl, tree copy)
        function.  */
     ;
   else
-    /* Ordinary automatic local variables are now in the scope of the
-       new function.  */
-    DECL_CONTEXT (copy) = id->dst_fn;
+    {
+      /* Ordinary automatic local variables are now in the scope of the
+	 new function.  */
+      DECL_CONTEXT (copy) = id->dst_fn;
+      if (VAR_P (copy) && id->dst_simt_vars && !is_gimple_reg (copy))
+	{
+	  if (!lookup_attribute ("omp simt private", DECL_ATTRIBUTES (copy)))
+	    DECL_ATTRIBUTES (copy)
+	      = tree_cons (get_identifier ("omp simt private"), NULL,
+			   DECL_ATTRIBUTES (copy));
+	  id->dst_simt_vars->safe_push (copy);
+	}
+    }
 
   return copy;
 }
diff --git a/gcc/tree-inline.h b/gcc/tree-inline.h
index 88b3286..ffb8333 100644
--- a/gcc/tree-inline.h
+++ b/gcc/tree-inline.h
@@ -145,6 +145,10 @@  struct copy_body_data
      equivalents in the function into which it is being inlined.  */
   hash_map<dependence_hash, unsigned short> *dependence_map;
 
+  /* A list of addressable local variables remapped into the caller
+     when inlining a call within an OpenMP SIMD-on-SIMT loop.  */
+  vec<tree> *dst_simt_vars;
+
   /* Cilk keywords currently need to replace some variables that
      ordinary nested functions do not.  */
   bool remap_var_for_cilk;