[ovs-dev,2/3] ofproto-dpif-rid: Update comment for recirc_alloc_id__().
diff mbox

Message ID 1490250377-9519-2-git-send-email-jpettit@ovn.org
State Accepted
Headers show

Commit Message

Justin Pettit March 23, 2017, 6:26 a.m. UTC
The hash is not recomputed if it is passed in as 0.

Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 ofproto/ofproto-dpif-rid.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jarno Rajahalme March 23, 2017, 4:59 p.m. UTC | #1
Acked-by: Jarno Rajahalme <jarno@ovn.org>

> On Mar 22, 2017, at 11:26 PM, Justin Pettit <jpettit@ovn.org> wrote:
> 
> The hash is not recomputed if it is passed in as 0.
> 
> Signed-off-by: Justin Pettit <jpettit@ovn.org>
> ---
> ofproto/ofproto-dpif-rid.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
> index d27669ef1f68..9381dee61404 100644
> --- a/ofproto/ofproto-dpif-rid.c
> +++ b/ofproto/ofproto-dpif-rid.c
> @@ -216,8 +216,7 @@ frozen_state_free(struct frozen_state *state)
> 
> /* Allocate a unique recirculation id for the given set of flow metadata.
>  * The ID space is 2^^32, so there should never be a situation in which all
> - * the IDs are used up.  We loop until we find a free one.
> - * hash is recomputed if it is passed in as 0. */
> + * the IDs are used up.  We loop until we find a free one. */
> static struct recirc_id_node *
> recirc_alloc_id__(const struct frozen_state *state, uint32_t hash)
> {
> -- 
> 2.7.4
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Patch
diff mbox

diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
index d27669ef1f68..9381dee61404 100644
--- a/ofproto/ofproto-dpif-rid.c
+++ b/ofproto/ofproto-dpif-rid.c
@@ -216,8 +216,7 @@  frozen_state_free(struct frozen_state *state)
 
 /* Allocate a unique recirculation id for the given set of flow metadata.
  * The ID space is 2^^32, so there should never be a situation in which all
- * the IDs are used up.  We loop until we find a free one.
- * hash is recomputed if it is passed in as 0. */
+ * the IDs are used up.  We loop until we find a free one. */
 static struct recirc_id_node *
 recirc_alloc_id__(const struct frozen_state *state, uint32_t hash)
 {