| Message ID | 20170303143226.13872-2-maxime.ripard@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | 522c282ff4800886cdc60d9b363adcb07c9131ee |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On Fri, Mar 3, 2017 at 10:32 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > If we depend on the ARCH_SUNXI configuration option, the boards that do not > have NAND support enabled (with the associated options) will not compile > anymore. > > Depend on the NAND driver configuration option to make sure that is not the > case. > > Reported-by: Chen-Yu Tsai <wens@csie.org> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Tested-by: Chen-Yu Tsai <wens@csie.org> > --- > cmd/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 585a00c31f4e..91e3d6a46769 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -438,7 +438,7 @@ config CMD_MMC > > config CMD_NAND > bool "nand" > - default y if ARCH_SUNXI > + default y if NAND_SUNXI It would be nicer if it were a stronger constraint though. The user can still enable CMD_NAND (such as by using a config from before this patch was applied) and still break the build. I understand that this is hard to achieve since each platform does things a bit differently. ChenYu > help > NAND support. > > @@ -847,7 +847,7 @@ config CMD_UBI > tristate "Enable UBI - Unsorted block images commands" > select CRC32 > select MTD_UBI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBI is a software layer above MTD layer which admits use of LVM-like > logical volumes on top of MTD devices, hides some complexities of > @@ -862,7 +862,7 @@ config CMD_UBIFS > select CRC32 > select RBTREE if ARCH_SUNXI > select LZO if ARCH_SUNXI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBIFS is a file system for flash devices which works on top of UBI. > > -- > 2.11.0 >
On 03/03/17 14:32, Maxime Ripard wrote: > If we depend on the ARCH_SUNXI configuration option, the boards that do not > have NAND support enabled (with the associated options) will not compile > anymore. > > Depend on the NAND driver configuration option to make sure that is not the > case. > Reported-by: Chen-Yu Tsai <wens@csie.org> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> As I came up with an identical patch today to fix sunxi/master: Reviewed-by: Andre Przywara <andre.przywara@arm.com> So this situation is a bit unfortunate: The sunxi/master branch was updated apparently before even compile-testing it for more than one sunxi board (it is broken for every sunxi board except Chip Pro at the moment: buildman says 105/106). And even after reports and the corresponding fixes appeared (thanks Chen-Yu and Maxime!) the branch is _still_ broken as of today (10 days after the fix was posted). So can we please have both a) a better quality assurance before merging patches into this custodian branch and b) quicker merging of fixes? To my understanding u-boot-sunxi should be always a good and working candidate for anyone interested in Allwinner boards. For a) it would already help to just simply build test sunxi: $ tools/buildman/buildman sunxi but probably extend this to cover at least all ARM boards. Cheers, Andre > --- > cmd/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 585a00c31f4e..91e3d6a46769 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -438,7 +438,7 @@ config CMD_MMC > > config CMD_NAND > bool "nand" > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > NAND support. > > @@ -847,7 +847,7 @@ config CMD_UBI > tristate "Enable UBI - Unsorted block images commands" > select CRC32 > select MTD_UBI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBI is a software layer above MTD layer which admits use of LVM-like > logical volumes on top of MTD devices, hides some complexities of > @@ -862,7 +862,7 @@ config CMD_UBIFS > select CRC32 > select RBTREE if ARCH_SUNXI > select LZO if ARCH_SUNXI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBIFS is a file system for flash devices which works on top of UBI. > >
Hi, On Mon, Mar 13, 2017 at 12:37:36AM +0000, André Przywara wrote: > On 03/03/17 14:32, Maxime Ripard wrote: > > If we depend on the ARCH_SUNXI configuration option, the boards that do not > > have NAND support enabled (with the associated options) will not compile > > anymore. > > > > Depend on the NAND driver configuration option to make sure that is not the > > case. > > > > Reported-by: Chen-Yu Tsai <wens@csie.org> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > As I came up with an identical patch today to fix sunxi/master: > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > > > So this situation is a bit unfortunate: The sunxi/master branch was > updated apparently before even compile-testing it for more than one > sunxi board (it is broken for every sunxi board except Chip Pro at the > moment: buildman says 105/106). And even after reports and the > corresponding fixes appeared (thanks Chen-Yu and Maxime!) the branch is > _still_ broken as of today (10 days after the fix was posted). > > So can we please have both > a) a better quality assurance before merging patches into this custodian > branch and > b) quicker merging of fixes? > To my understanding u-boot-sunxi should be always a good and working > candidate for anyone interested in Allwinner boards. > > For a) it would already help to just simply build test sunxi: > $ tools/buildman/buildman sunxi > but probably extend this to cover at least all ARM boards. Jagan usually takes the patches, but he seems to be off, and I was in holidays last week. I just pushed it, sorry for the breakage. Maxime
On Tuesday 21 March 2017 12:22 AM, Maxime Ripard wrote: > Hi, > > On Mon, Mar 13, 2017 at 12:37:36AM +0000, André Przywara wrote: >> On 03/03/17 14:32, Maxime Ripard wrote: >>> If we depend on the ARCH_SUNXI configuration option, the boards that do not >>> have NAND support enabled (with the associated options) will not compile >>> anymore. >>> >>> Depend on the NAND driver configuration option to make sure that is not the >>> case. >> >> >>> Reported-by: Chen-Yu Tsai <wens@csie.org> >>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> As I came up with an identical patch today to fix sunxi/master: >> >> Reviewed-by: Andre Przywara <andre.przywara@arm.com> >> >> >> So this situation is a bit unfortunate: The sunxi/master branch was >> updated apparently before even compile-testing it for more than one >> sunxi board (it is broken for every sunxi board except Chip Pro at the >> moment: buildman says 105/106). And even after reports and the >> corresponding fixes appeared (thanks Chen-Yu and Maxime!) the branch is >> _still_ broken as of today (10 days after the fix was posted). >> >> So can we please have both >> a) a better quality assurance before merging patches into this custodian >> branch and >> b) quicker merging of fixes? >> To my understanding u-boot-sunxi should be always a good and working >> candidate for anyone interested in Allwinner boards. >> >> For a) it would already help to just simply build test sunxi: >> $ tools/buildman/buildman sunxi >> but probably extend this to cover at least all ARM boards. > > Jagan usually takes the patches, but he seems to be off, and I was in > holidays last week. Sorry, I was off with holidays, will active and look for all. thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index 585a00c31f4e..91e3d6a46769 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -438,7 +438,7 @@ config CMD_MMC config CMD_NAND bool "nand" - default y if ARCH_SUNXI + default y if NAND_SUNXI help NAND support. @@ -847,7 +847,7 @@ config CMD_UBI tristate "Enable UBI - Unsorted block images commands" select CRC32 select MTD_UBI - default y if ARCH_SUNXI + default y if NAND_SUNXI help UBI is a software layer above MTD layer which admits use of LVM-like logical volumes on top of MTD devices, hides some complexities of @@ -862,7 +862,7 @@ config CMD_UBIFS select CRC32 select RBTREE if ARCH_SUNXI select LZO if ARCH_SUNXI - default y if ARCH_SUNXI + default y if NAND_SUNXI help UBIFS is a file system for flash devices which works on top of UBI.
If we depend on the ARCH_SUNXI configuration option, the boards that do not have NAND support enabled (with the associated options) will not compile anymore. Depend on the NAND driver configuration option to make sure that is not the case. Reported-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- cmd/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)