diff mbox

[U-Boot,v2,3/6] drivers: net: Provide Kconfig menu for PHYLIB

Message ID 20170207031737.2680-4-alex.g@adaptrum.com
State Accepted
Commit af2cbfd
Delegated to: Joe Hershberger
Headers show

Commit Message

Alexandru Gagniuc Feb. 7, 2017, 3:17 a.m. UTC 
Provide the necessary Kconfig symbols so that PHYLIB support may be
enabled in Kconfig, as opposed to needing to #define these symbols in
C source headers.

BITBANGMII and MV88E6352_SWITCH are left out of the PHYLIB submenu as
they don't seem to explicitly depend on it (i.e. they do not use the
phy_driver class).

Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
---
 drivers/net/Kconfig     | 28 ++-------------
 drivers/net/phy/Kconfig | 90 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 92 insertions(+), 26 deletions(-)
 create mode 100644 drivers/net/phy/Kconfig

Comments

Joe Hershberger Feb. 7, 2017, 4:28 p.m. UTC | #1 
On Mon, Feb 6, 2017 at 9:17 PM, Alexandru Gagniuc <alex.g@adaptrum.com> wrote:
> Provide the necessary Kconfig symbols so that PHYLIB support may be
> enabled in Kconfig, as opposed to needing to #define these symbols in
> C source headers.
>
> BITBANGMII and MV88E6352_SWITCH are left out of the PHYLIB submenu as
> they don't seem to explicitly depend on it (i.e. they do not use the
> phy_driver class).
>
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini Feb. 7, 2017, 6:23 p.m. UTC | #2 
On Mon, Feb 06, 2017 at 07:17:34PM -0800, Alexandru Gagniuc wrote:

> Provide the necessary Kconfig symbols so that PHYLIB support may be
> enabled in Kconfig, as opposed to needing to #define these symbols in
> C source headers.
> 
> BITBANGMII and MV88E6352_SWITCH are left out of the PHYLIB submenu as
> they don't seem to explicitly depend on it (i.e. they do not use the
> phy_driver class).
> 
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Joe Hershberger Feb. 9, 2017, 4:28 p.m. UTC | #3 
Hi Alex,

https://patchwork.ozlabs.org/patch/724968/ was applied to u-boot-net.git.

Thanks!
-Joe
Alexandru Gagniuc Feb. 9, 2017, 6:18 p.m. UTC | #4 
On 02/09/2017 08:28 AM, Joe Hershberger wrote:
> Hi Alex,
> Hi Joe
> https://patchwork.ozlabs.org/patch/724968/ was applied to u-boot-net.git.

Thanks!

I see that the name in the committer field got truncated. do you know if 
this is misconfiguration on my side or a patchwork bug?

Alex


> Thanks!
> -Joe
>
Joe Hershberger Feb. 9, 2017, 10:19 p.m. UTC | #5 
Hi Alex,

On Thu, Feb 9, 2017 at 12:18 PM, Alexandru Gagniuc <alex.g@adaptrum.com> wrote:
> On 02/09/2017 08:28 AM, Joe Hershberger wrote:
>>
>> Hi Alex,
>> Hi Joe
>> https://patchwork.ozlabs.org/patch/724968/ was applied to u-boot-net.git.
>
>
> Thanks!
>
> I see that the name in the committer field got truncated. do you know if
> this is misconfiguration on my side or a patchwork bug?

I suspect it must be something about your name or email configuration
in git. Patchwork seems to not like something about it. I guess it
could be a patchwork bug, but not sure what it might be.

Cheers,
-Joe

> Alex
>
>
>
>> Thanks!
>> -Joe
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Tom Rini Feb. 9, 2017, 10:45 p.m. UTC | #6 
On Thu, Feb 09, 2017 at 10:18:48AM -0800, Alexandru Gagniuc wrote:

> On 02/09/2017 08:28 AM, Joe Hershberger wrote:
> >Hi Alex,
> >Hi Joe
> >https://patchwork.ozlabs.org/patch/724968/ was applied to u-boot-net.git.
> 
> Thanks!
> 
> I see that the name in the committer field got truncated. do you
> know if this is misconfiguration on my side or a patchwork bug?

A little of both?  patchwork has your named saved as just 'Alex'.  We'll
take this off-list and sort it out.
diff mbox

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f52629f..93bc787 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1,3 +1,5 @@ 
+source "drivers/net/phy/Kconfig"
+
 config DM_ETH
 	bool "Enable Driver Model for Ethernet drivers"
 	depends on DM
@@ -8,32 +10,6 @@  config DM_ETH
 	  This is currently implemented in net/eth.c
 	  Look in include/net.h for details.
 
-config PHYLIB
-	bool "Ethernet PHY (physical media interface) support"
-	help
-	  Enable Ethernet PHY (physical media interface) support.
-
-config RTL8211X_PHY_FORCE_MASTER
-	bool "Ethernet PHY RTL8211x: force 1000BASE-T master mode"
-	depends on PHYLIB
-	help
-	  Force master mode for 1000BASE-T on RTl8211x PHYs (except for RTL8211F).
-	  This can work around link stability and data corruption issues on gigabit
-	  links which can occur in slave mode on certain PHYs, e.g. on the
-	  RTL8211C(L).
-
-	  Please note that two directly connected devices (i.e. via crossover cable)
-	  will not be able to establish a link between each other if they both force
-	  master mode. Multiple devices forcing master mode when connected by a
-	  network switch do not pose a problem as the switch configures its affected
-	  ports into slave mode.
-
-	  This option only affects gigabit links. If you must establish a direct
-	  connection between two devices which both force master mode, try forcing
-	  the link speed to 100MBit/s.
-
-	  If unsure, say N.
-
 menuconfig NETDEVICES
 	bool "Network device support"
 	depends on NET
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
new file mode 100644
index 0000000..52529f2
--- /dev/null
+++ b/drivers/net/phy/Kconfig
@@ -0,0 +1,90 @@ 
+
+config BITBANGMII
+	bool "Bit-banged ethernet MII management channel support"
+
+config MV88E6352_SWITCH
+	bool "Marvell 88E6352 switch support"
+
+menuconfig PHYLIB
+	bool "Ethernet PHY (physical media interface) support"
+	help
+	  Enable Ethernet PHY (physical media interface) support.
+
+if PHYLIB
+
+config MV88E61XX_SWITCH
+	bool "Marvel MV88E61xx Ethernet switch PHY support."
+
+config PHYLIB_10G
+	bool "Generic 10G PHY support"
+
+config PHY_AQUANTIA
+	bool "Aquantia Ethernet PHYs support"
+
+config PHY_ATHEROS
+	bool "Atheros Ethernet PHYs support"
+
+config PHY_BROADCOM
+	bool "Broadcom Ethernet PHYs support"
+
+config PHY_CORTINA
+	bool "Cortina Ethernet PHYs support"
+
+config PHY_DAVICOM
+	bool "Davicom Ethernet PHYs support"
+
+config PHY_ET1011C
+	bool "LSI TruePHY ET1011C support"
+
+config PHY_LXT
+	bool "LXT971 Ethernet PHY support"
+
+config PHY_MARVELL
+	bool "Marvell Ethernet PHYs support"
+
+config PHY_MICREL
+	bool "Micrel Ethernet PHYs support"
+
+config PHY_NATSEMI
+	bool "National Semiconductor Ethernet PHYs support"
+
+config PHY_REALTEK
+	bool "Realtek Ethernet PHYs support"
+
+config RTL8211X_PHY_FORCE_MASTER
+	bool "Ethernet PHY RTL8211x: force 1000BASE-T master mode"
+	depends on PHY_REALTEK
+	help
+	  Force master mode for 1000BASE-T on RTl8211x PHYs (except for RTL8211F).
+	  This can work around link stability and data corruption issues on gigabit
+	  links which can occur in slave mode on certain PHYs, e.g. on the
+	  RTL8211C(L).
+
+	  Please note that two directly connected devices (i.e. via crossover cable)
+	  will not be able to establish a link between each other if they both force
+	  master mode. Multiple devices forcing master mode when connected by a
+	  network switch do not pose a problem as the switch configures its affected
+	  ports into slave mode.
+
+	  This option only affects gigabit links. If you must establish a direct
+	  connection between two devices which both force master mode, try forcing
+	  the link speed to 100MBit/s.
+
+	  If unsure, say N.
+
+config PHY_SMSC
+	bool  "Microchip(SMSC) Ethernet PHYs support"
+
+config PHY_TERANETICS
+	bool "Teranetics Ethernet PHYs support"
+
+config PHY_TI
+	bool "Texas Instruments Ethernet PHYs support"
+
+config PHY_VITESSE
+	bool "Vitesse Ethernet PHYs support"
+
+config PHY_XILINX
+	bool "Xilinx Ethernet PHYs support"
+
+endif #PHYLIB