diff mbox

[U-Boot] net: fec_mxc: Fix corruption of device tree blob.

Message ID 20170202111140.12112-1-strnadda@gmail.com
State Accepted
Commit 5ad9204fa9b2eb592f8c9868b23904638987bbd0
Delegated to: Joe Hershberger
Headers show

Commit Message

Daniel Strnad Feb. 2, 2017, 11:11 a.m. UTC 
Modifying content of dev->name leads to the device tree corruption
because it points to the node name located there.

Signed-off-by: Daniel Strnad <strnadda@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/net/fec_mxc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Joe Hershberger Feb. 2, 2017, 5:56 p.m. UTC | #1 
On Thu, Feb 2, 2017 at 5:11 AM, Daniel Strnad <strnadda@gmail.com> wrote:
> Modifying content of dev->name leads to the device tree corruption
> because it points to the node name located there.
>
> Signed-off-by: Daniel Strnad <strnadda@gmail.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger Feb. 9, 2017, 4:27 p.m. UTC | #2 
Hi Daniel,

https://patchwork.ozlabs.org/patch/722979/ was applied to u-boot-net.git.

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 3304fddc69..9e9b8beb92 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1240,7 +1240,6 @@  static int fecmxc_probe(struct udevice *dev)
 	}
 
 	fec_reg_setup(priv);
-	fec_set_dev_name((char *)dev->name, dev_id);
 	priv->dev_id = (dev_id == -1) ? 0 : dev_id;
 
 	return 0;