| Message ID | 1484669670-4201-3-git-send-email-yendapally.reddy@broadcom.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 01/17/2017 08:14 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Initialize mdio clock divisor in probe function. The ext bus > bit available in the same register will be used by mdio mux > to enable external mdio. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On 01/17/2017 08:14 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Initialize mdio clock divisor in probe function. The ext bus > bit available in the same register will be used by mdio mux > to enable external mdio. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> David, this patch should go through your tree (but we forgot to CC you), patch in patchwork is here: http://patchwork.ozlabs.org/patch/716281/ Thanks! > --- > drivers/net/phy/mdio-bcm-iproc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c > index c0b4e65..46fe1ae 100644 > --- a/drivers/net/phy/mdio-bcm-iproc.c > +++ b/drivers/net/phy/mdio-bcm-iproc.c > @@ -81,8 +81,6 @@ static int iproc_mdio_read(struct mii_bus *bus, int phy_id, int reg) > if (rc) > return rc; > > - iproc_mdio_config_clk(priv->base); > - > /* Prepare the read operation */ > cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | > (reg << MII_DATA_RA_SHIFT) | > @@ -112,8 +110,6 @@ static int iproc_mdio_write(struct mii_bus *bus, int phy_id, > if (rc) > return rc; > > - iproc_mdio_config_clk(priv->base); > - > /* Prepare the write operation */ > cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | > (reg << MII_DATA_RA_SHIFT) | > @@ -163,6 +159,8 @@ static int iproc_mdio_probe(struct platform_device *pdev) > bus->read = iproc_mdio_read; > bus->write = iproc_mdio_write; > > + iproc_mdio_config_clk(priv->base); > + > rc = of_mdiobus_register(bus, pdev->dev.of_node); > if (rc) { > dev_err(&pdev->dev, "MDIO bus registration failed\n"); >
diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c index c0b4e65..46fe1ae 100644 --- a/drivers/net/phy/mdio-bcm-iproc.c +++ b/drivers/net/phy/mdio-bcm-iproc.c @@ -81,8 +81,6 @@ static int iproc_mdio_read(struct mii_bus *bus, int phy_id, int reg) if (rc) return rc; - iproc_mdio_config_clk(priv->base); - /* Prepare the read operation */ cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | (reg << MII_DATA_RA_SHIFT) | @@ -112,8 +110,6 @@ static int iproc_mdio_write(struct mii_bus *bus, int phy_id, if (rc) return rc; - iproc_mdio_config_clk(priv->base); - /* Prepare the write operation */ cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | (reg << MII_DATA_RA_SHIFT) | @@ -163,6 +159,8 @@ static int iproc_mdio_probe(struct platform_device *pdev) bus->read = iproc_mdio_read; bus->write = iproc_mdio_write; + iproc_mdio_config_clk(priv->base); + rc = of_mdiobus_register(bus, pdev->dev.of_node); if (rc) { dev_err(&pdev->dev, "MDIO bus registration failed\n");
Initialize mdio clock divisor in probe function. The ext bus bit available in the same register will be used by mdio mux to enable external mdio. Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> --- drivers/net/phy/mdio-bcm-iproc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)