From patchwork Wed Dec 14 16:38:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 705717 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tf2Mn6VLfz9t0v for ; Thu, 15 Dec 2016 03:39:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932473AbcLNQi5 (ORCPT ); Wed, 14 Dec 2016 11:38:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35674 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932436AbcLNQi5 (ORCPT ); Wed, 14 Dec 2016 11:38:57 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF9B9732; Wed, 14 Dec 2016 16:38:56 +0000 (UTC) Received: from shalem.localdomain.com (vpn1-5-28.ams2.redhat.com [10.36.5.28]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBEGcsXG019497; Wed, 14 Dec 2016 11:38:55 -0500 From: Hans de Goede To: Sebastian Reichel , Chen-Yu Tsai Cc: "russianneuromancer @ ya . ru" , linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org, Hans de Goede Subject: [PATCH 1/4] power: supply: axp288_fuel_gauge: Fix fuel_gauge_reg_readb return on error Date: Wed, 14 Dec 2016 17:38:50 +0100 Message-Id: <20161214163853.454-1-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 14 Dec 2016 16:38:56 +0000 (UTC) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org If reading the register fails, return the actual error code, instead of the uninitialized val variable; Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_fuel_gauge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c index 5bdde69..f62f9df 100644 --- a/drivers/power/supply/axp288_fuel_gauge.c +++ b/drivers/power/supply/axp288_fuel_gauge.c @@ -169,8 +169,10 @@ static int fuel_gauge_reg_readb(struct axp288_fg_info *info, int reg) break; } - if (ret < 0) + if (ret < 0) { dev_err(&info->pdev->dev, "axp288 reg read err:%d\n", ret); + return ret; + } return val; }