| Message ID | 20161205223853.29234-4-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <blp@ovn.org> wrote: > -Wnull-dereference is also new in GCC 6 but upon testing it produces far > too many false positives to be usable for OVS. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > Acked-by: Andy Zhou <azhou@ovn.org>
On Tue, Dec 06, 2016 at 06:10:01PM -0800, Andy Zhou wrote: > On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <blp@ovn.org> wrote: > > > -Wnull-dereference is also new in GCC 6 but upon testing it produces far > > too many false positives to be usable for OVS. > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > > Acked-by: Andy Zhou <azhou@ovn.org> Thanks for the reviews. I applied these to master.
diff --git a/configure.ac b/configure.ac index b3ade95..4414230 100644 --- a/configure.ac +++ b/configure.ac @@ -162,6 +162,8 @@ OVS_ENABLE_OPTION([-Wswitch-bool]) OVS_ENABLE_OPTION([-Wlogical-not-parentheses]) OVS_ENABLE_OPTION([-Wsizeof-array-argument]) OVS_ENABLE_OPTION([-Wbool-compare]) +OVS_ENABLE_OPTION([-Wshift-negative-value]) +OVS_ENABLE_OPTION([-Wduplicated-cond]) OVS_ENABLE_OPTION([-Qunused-arguments]) OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED]) OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter], [HAVE_WNO_UNUSED_PARAMETER])
-Wnull-dereference is also new in GCC 6 but upon testing it produces far too many false positives to be usable for OVS. Signed-off-by: Ben Pfaff <blp@ovn.org> --- configure.ac | 2 ++ 1 file changed, 2 insertions(+)