| Message ID | 20161205153937.8288-6-aserdean@cloudbasesolutions.com |
|---|---|
| State | Superseded |
| Delegated to: | Guru Shetty |
| Headers | show |
Acked-by: Sairam Venugopal <vsairam@vmware.com> On 12/5/16, 7:39 AM, "Alin Serdean" <aserdean@cloudbasesolutions.com> wrote: >Compiling with the WDK 10 gave the following warning: >Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to >'UINT32' >ovsext (OVSExt\ovsext) Conntrack.c 1139 > >This patch disables the warning on the file Conntrack.c. > >Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> >--- > datapath-windows/ovsext/Conntrack.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/datapath-windows/ovsext/Conntrack.c >b/datapath-windows/ovsext/Conntrack.c >index 84c4091..bdcf42c 100644 >--- a/datapath-windows/ovsext/Conntrack.c >+++ b/datapath-windows/ovsext/Conntrack.c >@@ -25,6 +25,9 @@ > #include "Debug.h" > #include "Event.h" > >+#pragma warning( push ) >+#pragma warning( disable:4311 ) >+ > #define WINDOWS_TICK 10000000 > #define SEC_TO_UNIX_EPOCH 11644473600LL > #define SEC_TO_NANOSEC 1000000000LL >@@ -1266,3 +1269,5 @@ OvsCtDumpCmdHandler(POVS_USER_PARAMS_CONTEXT >usrParamsCtx, > > return STATUS_SUCCESS; > } >+ >+#pragma warning( pop ) >-- >2.10.2.windows.1 >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_ >mailman_listinfo_ovs-2Ddev&d=DgICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5 >ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=BS1OWdyu5cSdkGAEbbMZaRxr3GuDqZgzwJ1urJX >JB3Y&s=PEbPYkzJLqSZ3NPqk7914CeqaZZL4cQNSQSWJ-32Dag&e=
On 5 December 2016 at 07:39, Alin Serdean <aserdean@cloudbasesolutions.com> wrote: > Compiling with the WDK 10 gave the following warning: > Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to > 'UINT32' > ovsext (OVSExt\ovsext) Conntrack.c 1139 > > This patch disables the warning on the file Conntrack.c. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > Would you mind reposting this? It gives me rejects. > --- > datapath-windows/ovsext/Conntrack.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/datapath-windows/ovsext/Conntrack.c > b/datapath-windows/ovsext/Conntrack.c > index 84c4091..bdcf42c 100644 > --- a/datapath-windows/ovsext/Conntrack.c > +++ b/datapath-windows/ovsext/Conntrack.c > @@ -25,6 +25,9 @@ > #include "Debug.h" > #include "Event.h" > > +#pragma warning( push ) > +#pragma warning( disable:4311 ) > + > #define WINDOWS_TICK 10000000 > #define SEC_TO_UNIX_EPOCH 11644473600LL > #define SEC_TO_NANOSEC 1000000000LL > @@ -1266,3 +1269,5 @@ OvsCtDumpCmdHandler(POVS_USER_PARAMS_CONTEXT > usrParamsCtx, > > return STATUS_SUCCESS; > } > + > +#pragma warning( pop ) > -- > 2.10.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Hi Guru, I rebased the patch: http://patchwork.ozlabs.org/patch/709440/ Thanks, Alin. From: Guru Shetty [mailto:guru@ovn.org] Sent: Thursday, December 22, 2016 1:07 AM To: Alin Serdean <aserdean@cloudbasesolutions.com> Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 5/5] datapath-windows: Conntrack disable type truncation warning On 5 December 2016 at 07:39, Alin Serdean <aserdean@cloudbasesolutions.com<mailto:aserdean@cloudbasesolutions.com>> wrote: Compiling with the WDK 10 gave the following warning: Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to 'UINT32' ovsext (OVSExt\ovsext) Conntrack.c 1139 This patch disables the warning on the file Conntrack.c. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com<mailto:aserdean@cloudbasesolutions.com>> Would you mind reposting this? It gives me rejects.
diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index 84c4091..bdcf42c 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -25,6 +25,9 @@ #include "Debug.h" #include "Event.h" +#pragma warning( push ) +#pragma warning( disable:4311 ) + #define WINDOWS_TICK 10000000 #define SEC_TO_UNIX_EPOCH 11644473600LL #define SEC_TO_NANOSEC 1000000000LL @@ -1266,3 +1269,5 @@ OvsCtDumpCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, return STATUS_SUCCESS; } + +#pragma warning( pop )
Compiling with the WDK 10 gave the following warning: Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to 'UINT32' ovsext (OVSExt\ovsext) Conntrack.c 1139 This patch disables the warning on the file Conntrack.c. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- datapath-windows/ovsext/Conntrack.c | 5 +++++ 1 file changed, 5 insertions(+)