| Message ID | 1478824444-20132-1-git-send-email-stewart@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
The problem is that pre 4.2 kernels lack the patch to create the irqdomain for the interrupt-parent so when the generic kernel code tries to register the IRQ it can't find the domain and barfs spurious warnings. 4.2+ kernels already detect the case where the irqdomain exists but the interrupt-parent property isn't set and fix things up appropriately which makes this patch nice to have rather than necessary. Acked-By: Alistair Popple <alistair@popple.id.au> On Fri, 11 Nov 2016 11:34:04 AM Stewart Smith wrote: > This reverts commit d997e482705d9fdff8e25fcbe07fb56008f96ae1. > > A problem was found with pre 4.2 linux kernels where a spurious WARNING > would be emitted. This change doesn't matter enough to scare users > so we can just revert it. > > Reported-by: Pridhiviraj Paidipeddi <ppaidipe@in.ibm.com> > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> > --- > core/ipmi-opal.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/core/ipmi-opal.c b/core/ipmi-opal.c > index c86f20d..1b28aa6 100644 > --- a/core/ipmi-opal.c > +++ b/core/ipmi-opal.c > @@ -127,7 +127,7 @@ out_unlock: > > void ipmi_opal_init(void) > { > - struct dt_node *opal_ipmi, *opal_event; > + struct dt_node *opal_ipmi; > > opal_ipmi = dt_new(opal_node, "ipmi"); > dt_add_property_strings(opal_ipmi, "compatible", "ibm,opal-ipmi"); > @@ -135,10 +135,6 @@ void ipmi_opal_init(void) > IPMI_DEFAULT_INTERFACE); > dt_add_property_cells(opal_ipmi, "interrupts", > ilog2(ipmi_backend->opal_event_ipmi_recv)); > - opal_event = dt_find_by_name(opal_node, "event"); > - if (opal_event) > - dt_add_property_cells(opal_ipmi, "interrupt-parent", > - opal_event->phandle); > > opal_register(OPAL_IPMI_SEND, opal_ipmi_send, 3); > opal_register(OPAL_IPMI_RECV, opal_ipmi_recv, 3); >
Stewart Smith <stewart@linux.vnet.ibm.com> writes: > This reverts commit d997e482705d9fdff8e25fcbe07fb56008f96ae1. > > A problem was found with pre 4.2 linux kernels where a spurious WARNING > would be emitted. This change doesn't matter enough to scare users > so we can just revert it. > > Reported-by: Pridhiviraj Paidipeddi <ppaidipe@in.ibm.com> > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> Merged to master as of a37b968141eb33d9be481f0e7b94d510b1569231
diff --git a/core/ipmi-opal.c b/core/ipmi-opal.c index c86f20d..1b28aa6 100644 --- a/core/ipmi-opal.c +++ b/core/ipmi-opal.c @@ -127,7 +127,7 @@ out_unlock: void ipmi_opal_init(void) { - struct dt_node *opal_ipmi, *opal_event; + struct dt_node *opal_ipmi; opal_ipmi = dt_new(opal_node, "ipmi"); dt_add_property_strings(opal_ipmi, "compatible", "ibm,opal-ipmi"); @@ -135,10 +135,6 @@ void ipmi_opal_init(void) IPMI_DEFAULT_INTERFACE); dt_add_property_cells(opal_ipmi, "interrupts", ilog2(ipmi_backend->opal_event_ipmi_recv)); - opal_event = dt_find_by_name(opal_node, "event"); - if (opal_event) - dt_add_property_cells(opal_ipmi, "interrupt-parent", - opal_event->phandle); opal_register(OPAL_IPMI_SEND, opal_ipmi_send, 3); opal_register(OPAL_IPMI_RECV, opal_ipmi_recv, 3);
This reverts commit d997e482705d9fdff8e25fcbe07fb56008f96ae1. A problem was found with pre 4.2 linux kernels where a spurious WARNING would be emitted. This change doesn't matter enough to scare users so we can just revert it. Reported-by: Pridhiviraj Paidipeddi <ppaidipe@in.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- core/ipmi-opal.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)