diff mbox

[ovs-dev] ovn-nb: Document the syntax for an address set name.

Message ID 1475856013-30389-1-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Oct. 7, 2016, 4 p.m. UTC
Also, it is not necessary to specify that the name must be unique because
the schema documentation generator does that for us.

Reported-by: Kevin Lin <kevinlin@berkeley.edu>
Reported-at: http://openvswitch.org/pipermail/dev/2016-October/080386.html
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 AUTHORS        | 1 +
 ovn/ovn-nb.xml | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Ben Pfaff Nov. 2, 2016, 4:57 p.m. UTC | #1
On Fri, Oct 07, 2016 at 09:00:13AM -0700, Ben Pfaff wrote:
> Also, it is not necessary to specify that the name must be unique because
> the schema documentation generator does that for us.
> 
> Reported-by: Kevin Lin <kevinlin@berkeley.edu>
> Reported-at: http://openvswitch.org/pipermail/dev/2016-October/080386.html
> Signed-off-by: Ben Pfaff <blp@ovn.org>

This needs a review, which should be easy.
Russell Bryant Nov. 3, 2016, 5:35 p.m. UTC | #2
On Wed, Nov 2, 2016 at 5:57 PM, Ben Pfaff <blp@ovn.org> wrote:

> On Fri, Oct 07, 2016 at 09:00:13AM -0700, Ben Pfaff wrote:
> > Also, it is not necessary to specify that the name must be unique because
> > the schema documentation generator does that for us.
> >
> > Reported-by: Kevin Lin <kevinlin@berkeley.edu>
> > Reported-at: http://openvswitch.org/pipermail/dev/2016-October/
> 080386.html
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
>
> This needs a review, which should be easy.


Acked-by: Russell Bryant <russell@ovn.org>
diff mbox

Patch

diff --git a/AUTHORS b/AUTHORS
index a30a5d8..46bd59e 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -371,6 +371,7 @@  John Hurley             john.hurley@netronome.com
 John Reumann            nofutznetworks@gmail.com
 Kashyap Thimmaraju      kashyap.thimmaraju@sec.t-labs.tu-berlin.de
 Keith Holleman          hollemanietf@gmail.com
+Kevin Lin               kevinlin@berkeley.edu
 K 華                    k940545@hotmail.com
 Kevin Mancuso           kevin.mancuso@rackspace.com
 Kiran Shanbhog          kiran@vmware.com
diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
index e1b3136..a8943d8 100644
--- a/ovn/ovn-nb.xml
+++ b/ovn/ovn-nb.xml
@@ -691,7 +691,8 @@ 
     </p>
 
     <column name="name">
-      A name for the address set.  This must be unique among all address sets.
+      A name for the address set.  Names are ASCII and must match
+      <code>[a-zA-Z_.][a-zA-Z_.0-9]*</code>.
     </column>
 
     <column name="addresses">