[ovs-dev,1/3] jsonrpc: Improve comment for jsonrpc_get_status().
diff mbox

Message ID 1474050422-4330-1-git-send-email-jpettit@ovn.org
State Accepted
Headers show

Commit Message

Justin Pettit Sept. 16, 2016, 6:27 p.m. UTC
Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 lib/jsonrpc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Ben Pfaff Sept. 19, 2016, 3:19 p.m. UTC | #1
On Fri, Sep 16, 2016 at 11:27:00AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit@ovn.org>

I think that this was a one-word change, plus rewrapping.

Acked-by: Ben Pfaff <blp@ovn.org>
Justin Pettit Sept. 19, 2016, 4:10 p.m. UTC | #2
> On Sep 19, 2016, at 8:19 AM, Ben Pfaff <blp@ovn.org> wrote:
> 
> On Fri, Sep 16, 2016 at 11:27:00AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit@ovn.org>
> 
> I think that this was a one-word change, plus rewrapping.

Yes, it added a word that then increased the line length of that line past 80 columns, so I rewrapped it.

> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks.  I'll push it in a minute.

--Justin

Patch
diff mbox

diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index 1841568..a0ade9c 100644
--- a/lib/jsonrpc.c
+++ b/lib/jsonrpc.c
@@ -156,11 +156,11 @@  jsonrpc_wait(struct jsonrpc *rpc)
  * - >0: errno value
  * - EOF: end of file (remote end closed connection; not necessarily an error).
  *
- * When this functions nonzero, 'rpc' is effectively out of commission.  'rpc'
- * will not receive any more messages and any further messages that one
- * attempts to send with 'rpc' will be discarded.  The caller can keep 'rpc'
- * around as long as it wants, but it's not going to provide any more useful
- * services.
+ * When this function returns nonzero, 'rpc' is effectively out of
+ * commission.  'rpc' will not receive any more messages and any further
+ * messages that one attempts to send with 'rpc' will be discarded.  The
+ * caller can keep 'rpc' around as long as it wants, but it's not going
+ * to provide any more useful services.
  */
 int
 jsonrpc_get_status(const struct jsonrpc *rpc)