| Message ID | 1473899205-12313-4-git-send-email-e@erig.me |
|---|---|
| State | Superseded |
| Headers | show |
On 14 September 2016 at 17:26, Eric Garver <e@erig.me> wrote:
> Signed-off-by: Eric Garver <e@erig.me>
Hi Eric,
I tried this series again on a variety of kernels and these initial
ping over cvlan tests are failing for check-system-userspace on older
kernels (3.10,3.13) due to reasons we had discussed a bit on the
previous version of this patch series.
Were you planning to take a look at either getting the userspace
datapath to work around these cases, or skip the tests for such
kernels?
On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote: > On 14 September 2016 at 17:26, Eric Garver <e@erig.me> wrote: > > Signed-off-by: Eric Garver <e@erig.me> > > Hi Eric, > > I tried this series again on a variety of kernels and these initial > ping over cvlan tests are failing for check-system-userspace on older > kernels (3.10,3.13) due to reasons we had discussed a bit on the > previous version of this patch series. > > Were you planning to take a look at either getting the userspace > datapath to work around these cases, or skip the tests for such > kernels? > I would prefer to fix the issue in userspace. I'll have a go at it today. How did the rest of the test cases look? You should be able to run "check-kernel" on a recent net-next. Thanks for the feedback!
Joe, I have a pretty straight forward fix for the TPID issue. I'll be sending it to ovs-dev shortly. However, I had to make a small change to one of my tests to support it. So I'll be sending out another rev of this test series as well. Thanks. Eric. On Fri, Sep 23, 2016 at 08:51:42AM -0400, Eric Garver wrote: > On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote: > > On 14 September 2016 at 17:26, Eric Garver <e@erig.me> wrote: > > > Signed-off-by: Eric Garver <e@erig.me> > > > > Hi Eric, > > > > I tried this series again on a variety of kernels and these initial > > ping over cvlan tests are failing for check-system-userspace on older > > kernels (3.10,3.13) due to reasons we had discussed a bit on the > > previous version of this patch series. > > > > Were you planning to take a look at either getting the userspace > > datapath to work around these cases, or skip the tests for such > > kernels? > > > > I would prefer to fix the issue in userspace. I'll have a go at it > today. > > How did the rest of the test cases look? You should be able to run > "check-kernel" on a recent net-next. > > Thanks for the feedback! > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
On 23 September 2016 at 05:51, Eric Garver <e@erig.me> wrote: > On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote: >> On 14 September 2016 at 17:26, Eric Garver <e@erig.me> wrote: >> > Signed-off-by: Eric Garver <e@erig.me> >> >> Hi Eric, >> >> I tried this series again on a variety of kernels and these initial >> ping over cvlan tests are failing for check-system-userspace on older >> kernels (3.10,3.13) due to reasons we had discussed a bit on the >> previous version of this patch series. >> >> Were you planning to take a look at either getting the userspace >> datapath to work around these cases, or skip the tests for such >> kernels? >> > > I would prefer to fix the issue in userspace. I'll have a go at it > today. > > How did the rest of the test cases look? You should be able to run > "check-kernel" on a recent net-next. Oh, I forgot to mention check-kernel - that looked fine on all of my build targets. Thanks for looking into this.
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4dabd90356a1..83c7b8a2f4e5 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -69,6 +69,37 @@ NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3 -w 2 10.2.2.2 | FORMAT_PING OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP +AT_SETUP([datapath - ping between two ports on cvlan]) +OVS_TRAFFIC_VSWITCHD_START() + +AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"]) + +ADD_NAMESPACES(at_ns0, at_ns1) + +ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24") +ADD_VETH(p1, at_ns1, br0, "10.1.1.2/24") + +ADD_SVLAN(p0, at_ns0, 4094, "10.255.2.1/24") +ADD_SVLAN(p1, at_ns1, 4094, "10.255.2.2/24") + +ADD_CVLAN(p0.4094, at_ns0, 100, "10.2.2.1/24") +ADD_CVLAN(p1.4094, at_ns1, 100, "10.2.2.2/24") + +OVS_WAIT_UNTIL([ip netns exec at_ns0 ping -c 1 10.2.2.2]) + +NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.2.2.2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) +NS_CHECK_EXEC([at_ns0], [ping -s 1600 -q -c 3 -i 0.3 -w 2 10.2.2.2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) +NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3 -w 2 10.2.2.2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) + +OVS_TRAFFIC_VSWITCHD_STOP +AT_CLEANUP + AT_SETUP([datapath - ping6 between two ports]) OVS_TRAFFIC_VSWITCHD_START() @@ -128,6 +159,37 @@ NS_CHECK_EXEC([at_ns0], [ping6 -s 3200 -q -c 3 -i 0.3 -w 2 fc00:1::2 | FORMAT_PI OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP +AT_SETUP([datapath - ping6 between two ports on cvlan]) +OVS_TRAFFIC_VSWITCHD_START() + +AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"]) + +ADD_NAMESPACES(at_ns0, at_ns1) + +ADD_VETH(p0, at_ns0, br0, "fc00::1/96") +ADD_VETH(p1, at_ns1, br0, "fc00::2/96") + +ADD_SVLAN(p0, at_ns0, 4094, "fc00:ffff::1/96") +ADD_SVLAN(p1, at_ns1, 4094, "fc00:ffff::2/96") + +ADD_CVLAN(p0.4094, at_ns0, 100, "fc00:1::1/96") +ADD_CVLAN(p1.4094, at_ns1, 100, "fc00:1::2/96") + +OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00:1::2]) + +NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00:1::2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) +NS_CHECK_EXEC([at_ns0], [ping6 -s 1600 -q -c 3 -i 0.3 -w 2 fc00:1::2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) +NS_CHECK_EXEC([at_ns0], [ping6 -s 3200 -q -c 3 -i 0.3 -w 2 fc00:1::2 | FORMAT_PING], [0], [dnl +3 packets transmitted, 3 received, 0% packet loss, time 0ms +]) + +OVS_TRAFFIC_VSWITCHD_STOP +AT_CLEANUP + AT_SETUP([datapath - ping over bond]) OVS_TRAFFIC_VSWITCHD_START()
Signed-off-by: Eric Garver <e@erig.me> --- tests/system-traffic.at | 62 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+)