| Message ID | 1471975597-3808-1-git-send-email-hemant.agrawal@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
A gentle reminder to review this patch? > -----Original Message----- > From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Hemant > Agrawal > Sent: Tuesday, August 23, 2016 11:37 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] netdev-dpdk: fix cross compilation failure > > configure with_dpdk and cross compile fails with: > "configure: error: cannot check for file existence when cross compiling" > > This is due to the usages of AC_CHECK_FILES. > > AC_CHECK_FILES only works when not cross compiling. It test a feature of the > host machine, and therefore, die when cross-compiling. > > The current patch put the check in condition, i.e. check only if not cross- > compiling. > > This patch has been tested on ARM64 platform with DPDK16.07 > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- > acinclude.m4 | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 index 353519d..fd446b2 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -180,9 +180,13 @@ AC_DEFUN([OVS_CHECK_DPDK], [ > DPDK_INCLUDE="$with_dpdk/include" > # If 'with_dpdk' is passed install directory, point to headers > # installed in $DESTDIR/$prefix/include/dpdk > - AC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [], > + # AC_CHECK_FILES only works when not cross compiling > + if test "$cross_compiling" != "yes" > + then > + AC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [], > [AC_CHECK_FILE([$DPDK_INCLUDE/dpdk/rte_config.h], > [DPDK_INCLUDE=$DPDK_INCLUDE/dpdk], [])]) > + fi > DPDK_LIB_DIR="$with_dpdk/lib" > ;; > esac > -- > 1.9.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
diff --git a/acinclude.m4 b/acinclude.m4 index 353519d..fd446b2 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -180,9 +180,13 @@ AC_DEFUN([OVS_CHECK_DPDK], [ DPDK_INCLUDE="$with_dpdk/include" # If 'with_dpdk' is passed install directory, point to headers # installed in $DESTDIR/$prefix/include/dpdk - AC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [], + # AC_CHECK_FILES only works when not cross compiling + if test "$cross_compiling" != "yes" + then + AC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [], [AC_CHECK_FILE([$DPDK_INCLUDE/dpdk/rte_config.h], [DPDK_INCLUDE=$DPDK_INCLUDE/dpdk], [])]) + fi DPDK_LIB_DIR="$with_dpdk/lib" ;; esac
configure with_dpdk and cross compile fails with: "configure: error: cannot check for file existence when cross compiling" This is due to the usages of AC_CHECK_FILES. AC_CHECK_FILES only works when not cross compiling. It test a feature of the host machine, and therefore, die when cross-compiling. The current patch put the check in condition, i.e. check only if not cross-compiling. This patch has been tested on ARM64 platform with DPDK16.07 Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- acinclude.m4 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)