[ovs-dev,1/3] OVN-Tutorial: Replace example with ASCII quotes.
diff mbox

Message ID 1470895754-84811-1-git-send-email-jpettit@ovn.org
State Accepted
Headers show

Commit Message

Justin Pettit Aug. 11, 2016, 6:09 a.m. UTC
The "--ovn" argument for SANDBOXFLAGS used unicode quotes, which when
copy and pasted made the command mysteriously fail.

Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 tutorial/OVN-Tutorial.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lance Richardson Aug. 22, 2016, 6:39 p.m. UTC | #1
> From: "Justin Pettit" <jpettit@ovn.org>
> To: dev@openvswitch.org
> Sent: Thursday, August 11, 2016 2:09:12 AM
> Subject: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII	quotes.
> 
> The "--ovn" argument for SANDBOXFLAGS used unicode quotes, which when
> copy and pasted made the command mysteriously fail.
> 
> Signed-off-by: Justin Pettit <jpettit@ovn.org>
> ---
>  tutorial/OVN-Tutorial.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
> index be9805c..65e4ea2 100644
> --- a/tutorial/OVN-Tutorial.md
> +++ b/tutorial/OVN-Tutorial.md
> @@ -17,7 +17,7 @@ section of [Tutorial.md].
>  pass the `--ovn` flag.  For example, if running it straight from the ovs git
>  tree you would run:
>  
> -    $ make sandbox SANDBOXFLAGS=”--ovn”
> +    $ make sandbox SANDBOXFLAGS="--ovn"
>  
>  Running the sandbox with OVN enabled does the following additional steps to
>  the
>  environment:

Nice, I fell into this trap the first time I tried to run the ovn tutorials.

Acked-by: Lance Richardson <lrichard@redhat.com>
Flavio Fernandes Aug. 22, 2016, 7:47 p.m. UTC | #2
> On Aug 22, 2016, at 2:39 PM, Lance Richardson <lrichard@redhat.com> wrote:
> 
>> From: "Justin Pettit" <jpettit@ovn.org>
>> To: dev@openvswitch.org
>> Sent: Thursday, August 11, 2016 2:09:12 AM
>> Subject: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII	quotes.
>> 
>> The "--ovn" argument for SANDBOXFLAGS used unicode quotes, which when
>> copy and pasted made the command mysteriously fail.
>> 
>> Signed-off-by: Justin Pettit <jpettit@ovn.org>
>> ---
>> tutorial/OVN-Tutorial.md | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
>> index be9805c..65e4ea2 100644
>> --- a/tutorial/OVN-Tutorial.md
>> +++ b/tutorial/OVN-Tutorial.md
>> @@ -17,7 +17,7 @@ section of [Tutorial.md].
>> pass the `--ovn` flag.  For example, if running it straight from the ovs git
>> tree you would run:
>> 
>> -    $ make sandbox SANDBOXFLAGS=”--ovn”
>> +    $ make sandbox SANDBOXFLAGS="--ovn"
>> 
>> Running the sandbox with OVN enabled does the following additional steps to
>> the
>> environment:
> 
> Nice, I fell into this trap the first time I tried to run the ovn tutorials.

+1  :)

> 
> Acked-by: Lance Richardson <lrichard@redhat.com <mailto:lrichard@redhat.com>>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org <mailto:dev@openvswitch.org>
> http://openvswitch.org/mailman/listinfo/dev <http://openvswitch.org/mailman/listinfo/dev>
Justin Pettit Aug. 26, 2016, 4:12 p.m. UTC | #3
> On Aug 22, 2016, at 11:39 AM, Lance Richardson <lrichard@redhat.com> wrote:
> 
>> From: "Justin Pettit" <jpettit@ovn.org>
>> To: dev@openvswitch.org
>> Sent: Thursday, August 11, 2016 2:09:12 AM
>> Subject: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII	quotes.
>> 
>> The "--ovn" argument for SANDBOXFLAGS used unicode quotes, which when
>> copy and pasted made the command mysteriously fail.
>> 
>> Signed-off-by: Justin Pettit <jpettit@ovn.org>
>> ---
>> tutorial/OVN-Tutorial.md | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
>> index be9805c..65e4ea2 100644
>> --- a/tutorial/OVN-Tutorial.md
>> +++ b/tutorial/OVN-Tutorial.md
>> @@ -17,7 +17,7 @@ section of [Tutorial.md].
>> pass the `--ovn` flag.  For example, if running it straight from the ovs git
>> tree you would run:
>> 
>> -    $ make sandbox SANDBOXFLAGS=”--ovn”
>> +    $ make sandbox SANDBOXFLAGS="--ovn"
>> 
>> Running the sandbox with OVN enabled does the following additional steps to
>> the
>> environment:
> 
> Nice, I fell into this trap the first time I tried to run the ovn tutorials.
> 
> Acked-by: Lance Richardson <lrichard@redhat.com>

Thanks.  I'll push this in a minute.

--Justin

Patch
diff mbox

diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
index be9805c..65e4ea2 100644
--- a/tutorial/OVN-Tutorial.md
+++ b/tutorial/OVN-Tutorial.md
@@ -17,7 +17,7 @@  section of [Tutorial.md].
 pass the `--ovn` flag.  For example, if running it straight from the ovs git
 tree you would run:
 
-    $ make sandbox SANDBOXFLAGS=”--ovn”
+    $ make sandbox SANDBOXFLAGS="--ovn"
 
 Running the sandbox with OVN enabled does the following additional steps to the
 environment: