Message ID | 20160816053502.15187-2-mgr@nordkrater.de |
---|---|
State | Superseded |
Headers | show |
Hi Manuel, Le 16/08/2016 à 07:35, Manuel Groß a écrit : > This package provides websocketpp, a header only C++ library that implements websocket client and server functionality. Thanks for this contribution! There is another patch submitted by Pieter De Gendt for websocketpp: http://patchwork.ozlabs.org/patch/665214/ It would be great if you can review and test it. > > Signed-off-by: Manuel Groß <mgr@nordkrater.de> > --- > package/Config.in | 1 + > package/websocketpp/Config.in | 12 ++++++++++++ > package/websocketpp/websocketpp.mk | 21 +++++++++++++++++++++ > 3 files changed, 34 insertions(+) > create mode 100644 package/websocketpp/Config.in > create mode 100644 package/websocketpp/websocketpp.mk > > diff --git a/package/Config.in b/package/Config.in > index 645fa29..e99850d 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1242,6 +1242,7 @@ menu "Networking" > source "package/sofia-sip/Config.in" > source "package/thrift/Config.in" > source "package/usbredir/Config.in" > + source "package/websocketpp/Config.in" > source "package/wvstreams/Config.in" > source "package/zeromq/Config.in" > source "package/zmqpp/Config.in" > diff --git a/package/websocketpp/Config.in b/package/websocketpp/Config.in > new file mode 100644 > index 0000000..2b24b0d > --- /dev/null > +++ b/package/websocketpp/Config.in > @@ -0,0 +1,12 @@ > +config BR2_PACKAGE_WEBSOCKETPP > + bool "websocketpp" No dependency at all ? It seems at least boost package is needed. > + help > + WebSocket++ is a header only C++ library that implements RFC6455 The > + WebSocket Protocol. It allows integrating WebSocket client and server > + functionality into C++ programs. It uses interchangeable network > + transport modules including one based on raw char buffers, one based > + on C++ iostreams, and one based on Asio (either via Boost or > + standalone). End users can write additional transport policies to > + support other networking or event libraries as needed. > + > + http://www.zaphoyd.com/websocketpp/ > diff --git a/package/websocketpp/websocketpp.mk b/package/websocketpp/websocketpp.mk > new file mode 100644 > index 0000000..00f451f > --- /dev/null > +++ b/package/websocketpp/websocketpp.mk > @@ -0,0 +1,21 @@ > +################################################################################ > +# > +## websocketpp > +# > +################################################################################# > + > +WEBSOCKETPP_VERSION = 0.7.0 > +WEBSOCKETPP_SITE = $(call github,zaphoyd,websocketpp,$(WEBSOCKETPP_VERSION)) > +WEBSOCKETPP_INSTALL_STAGING = YES > +WEBSOCKETPP_LICENSE = BSD or MIT > +WEBSOCKETPP_LICENSE_FILES = COPYING > + > +WEBSOCKETPP_VERSION_CONF_OPTS = \ ^^^^^^^ Typo here, so this variable is not used during the build. > + CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ > + LDFLAGS="$(TARGET_LDFLAGS)" > + > +define WEBSOCKETPP_INSTALL_STAGING_CMDS > + cp -vR $(@D)/websocketpp $(STAGING_DIR)/usr/include/websocketpp > +endef > + > +$(eval $(generic-package)) websocketpp has a CMake build system, so it's recommended to use it. Since we have another patch for websocketpp, I'll mark it "Superseded" in the patchwork. Best regards, Romain >
Hi Romain, On Sat, 3 Sep 2016 18:53:39 +0200 Romain Naour <romain.naour@gmail.com> wrote: > Le 16/08/2016 à 07:35, Manuel Groß a écrit : > > This package provides websocketpp, a header only C++ library that > > implements websocket client and server functionality. > > Thanks for this contribution! > > There is another patch submitted by Pieter De Gendt for websocketpp: > http://patchwork.ozlabs.org/patch/665214/ > It would be great if you can review and test it. I had a look and also read the subsequent conversation on this list. The proposed changes already exceed my insight into the package. I just need it for a proprietary package I use, and for that I can include it as simple as in my patch. I'll follow the changes to that patch, but I'm afraid I won't be very helpful.
diff --git a/package/Config.in b/package/Config.in index 645fa29..e99850d 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1242,6 +1242,7 @@ menu "Networking" source "package/sofia-sip/Config.in" source "package/thrift/Config.in" source "package/usbredir/Config.in" + source "package/websocketpp/Config.in" source "package/wvstreams/Config.in" source "package/zeromq/Config.in" source "package/zmqpp/Config.in" diff --git a/package/websocketpp/Config.in b/package/websocketpp/Config.in new file mode 100644 index 0000000..2b24b0d --- /dev/null +++ b/package/websocketpp/Config.in @@ -0,0 +1,12 @@ +config BR2_PACKAGE_WEBSOCKETPP + bool "websocketpp" + help + WebSocket++ is a header only C++ library that implements RFC6455 The + WebSocket Protocol. It allows integrating WebSocket client and server + functionality into C++ programs. It uses interchangeable network + transport modules including one based on raw char buffers, one based + on C++ iostreams, and one based on Asio (either via Boost or + standalone). End users can write additional transport policies to + support other networking or event libraries as needed. + + http://www.zaphoyd.com/websocketpp/ diff --git a/package/websocketpp/websocketpp.mk b/package/websocketpp/websocketpp.mk new file mode 100644 index 0000000..00f451f --- /dev/null +++ b/package/websocketpp/websocketpp.mk @@ -0,0 +1,21 @@ +################################################################################ +# +## websocketpp +# +################################################################################# + +WEBSOCKETPP_VERSION = 0.7.0 +WEBSOCKETPP_SITE = $(call github,zaphoyd,websocketpp,$(WEBSOCKETPP_VERSION)) +WEBSOCKETPP_INSTALL_STAGING = YES +WEBSOCKETPP_LICENSE = BSD or MIT +WEBSOCKETPP_LICENSE_FILES = COPYING + +WEBSOCKETPP_VERSION_CONF_OPTS = \ + CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ + LDFLAGS="$(TARGET_LDFLAGS)" + +define WEBSOCKETPP_INSTALL_STAGING_CMDS + cp -vR $(@D)/websocketpp $(STAGING_DIR)/usr/include/websocketpp +endef + +$(eval $(generic-package))
This package provides websocketpp, a header only C++ library that implements websocket client and server functionality. Signed-off-by: Manuel Groß <mgr@nordkrater.de> --- package/Config.in | 1 + package/websocketpp/Config.in | 12 ++++++++++++ package/websocketpp/websocketpp.mk | 21 +++++++++++++++++++++ 3 files changed, 34 insertions(+) create mode 100644 package/websocketpp/Config.in create mode 100644 package/websocketpp/websocketpp.mk