| Message ID | 1470434333-17595-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2016-08-05 23:58 +0200, Thomas Petazzoni spake thusly: > Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started > failing to build. Since we can hardly fix that on our own, the issue was > reported upstream (https://sourceforge.net/p/owfs/support-requests/32/) > and for now, we will disable PHP support in OWFS. > > Fixes: > > http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/owfs/owfs.mk | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/package/owfs/owfs.mk b/package/owfs/owfs.mk > index 0092603..83614af 100644 > --- a/package/owfs/owfs.mk > +++ b/package/owfs/owfs.mk > @@ -17,6 +17,10 @@ OWFS_LICENSE = GPLv2+, LGPLv2 (owtcl) > OWFS_LICENSE_FILES = COPYING COPYING.LIB > OWFS_INSTALL_STAGING = YES > > +# owfs PHP support is not PHP 7 compliant > +# https://sourceforge.net/p/owfs/support-requests/32/ > +OWFS_CONF_OPTS += --disable-owphp --without-php > + > ifeq ($(BR2_PACKAGE_LIBFUSE),y) > OWFS_DEPENDENCIES += libfuse > OWFS_CONF_OPTS += \ > @@ -49,13 +53,6 @@ else > OWFS_CONF_OPTS += --disable-avahi > endif > > -ifeq ($(BR2_PACKAGE_PHP),y) > -OWFS_CONF_OPTS += --enable-owphp --with-php --with-phpconfig=$(STAGING_DIR)/usr/bin/php-config > -OWFS_DEPENDENCIES += php host-swig > -else > -OWFS_CONF_OPTS += --disable-owphp --without-php > -endif > - > # setup.py isn't python3 compliant > ifeq ($(BR2_PACKAGE_PYTHON),y) > OWFS_CONF_OPTS += \ > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Fri, 5 Aug 2016 23:58:53 +0200, Thomas Petazzoni wrote: > Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started > failing to build. Since we can hardly fix that on our own, the issue was > reported upstream (https://sourceforge.net/p/owfs/support-requests/32/) > and for now, we will disable PHP support in OWFS. > > Fixes: > > http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/owfs/owfs.mk | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) Applied to master, thanks. Thomas
diff --git a/package/owfs/owfs.mk b/package/owfs/owfs.mk index 0092603..83614af 100644 --- a/package/owfs/owfs.mk +++ b/package/owfs/owfs.mk @@ -17,6 +17,10 @@ OWFS_LICENSE = GPLv2+, LGPLv2 (owtcl) OWFS_LICENSE_FILES = COPYING COPYING.LIB OWFS_INSTALL_STAGING = YES +# owfs PHP support is not PHP 7 compliant +# https://sourceforge.net/p/owfs/support-requests/32/ +OWFS_CONF_OPTS += --disable-owphp --without-php + ifeq ($(BR2_PACKAGE_LIBFUSE),y) OWFS_DEPENDENCIES += libfuse OWFS_CONF_OPTS += \ @@ -49,13 +53,6 @@ else OWFS_CONF_OPTS += --disable-avahi endif -ifeq ($(BR2_PACKAGE_PHP),y) -OWFS_CONF_OPTS += --enable-owphp --with-php --with-phpconfig=$(STAGING_DIR)/usr/bin/php-config -OWFS_DEPENDENCIES += php host-swig -else -OWFS_CONF_OPTS += --disable-owphp --without-php -endif - # setup.py isn't python3 compliant ifeq ($(BR2_PACKAGE_PYTHON),y) OWFS_CONF_OPTS += \
Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started failing to build. Since we can hardly fix that on our own, the issue was reported upstream (https://sourceforge.net/p/owfs/support-requests/32/) and for now, we will disable PHP support in OWFS. Fixes: http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/owfs/owfs.mk | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)