diff mbox

[U-Boot,v2] net: smsc95xx: Use correct get_unaligned functions

Message ID 20160712215236.18160-1-judge.packham@gmail.com
State Accepted
Commit 70f1463
Delegated to: Joe Hershberger
Headers show

Commit Message

Chris Packham July 12, 2016, 9:52 p.m. UTC
The __get_unaligned_le* functions may not be declared on all platforms.
Instead, get_unaligned_le* should be used. On many platforms both of
these are the same function.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
Hi Joe,

Mark didn't manage to get to this before he went on leave so I've taken
it over.

Changes in v2:
- Remove gerrit reference from commit message
- Sign-off and change author

 drivers/usb/eth/smsc95xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joe Hershberger Aug. 4, 2016, 4:21 p.m. UTC | #1
On Tue, Jul 12, 2016 at 4:52 PM, Chris Packham <judge.packham@gmail.com> wrote:
> The __get_unaligned_le* functions may not be declared on all platforms.
> Instead, get_unaligned_le* should be used. On many platforms both of
> these are the same function.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger Aug. 15, 2016, 8:33 p.m. UTC | #2
Hi Chris,

https://patchwork.ozlabs.org/patch/647651/ was applied to u-boot-net.git.

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
index 08eaed5..7d9abfd 100644
--- a/drivers/usb/eth/smsc95xx.c
+++ b/drivers/usb/eth/smsc95xx.c
@@ -391,8 +391,8 @@  static int smsc95xx_write_hwaddr_common(struct usb_device *udev,
 					struct smsc95xx_private *priv,
 					unsigned char *enetaddr)
 {
-	u32 addr_lo = __get_unaligned_le32(&enetaddr[0]);
-	u32 addr_hi = __get_unaligned_le16(&enetaddr[4]);
+	u32 addr_lo = get_unaligned_le32(&enetaddr[0]);
+	u32 addr_hi = get_unaligned_le16(&enetaddr[4]);
 	int ret;
 
 	/* set hardware address */