From patchwork Sun Jul 3 17:14:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alin Serdean X-Patchwork-Id: 643795 X-Patchwork-Delegate: blp@nicira.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rjGxP240Rz9sBf for ; Mon, 4 Jul 2016 03:15:21 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 5866F10771; Sun, 3 Jul 2016 10:15:20 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 495F4101AC for ; Sun, 3 Jul 2016 10:15:19 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id B63B7163144 for ; Sun, 3 Jul 2016 11:15:18 -0600 (MDT) X-ASG-Debug-ID: 1467566118-0b32373f7c204180001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar6.cudamail.com with ESMTP id 3H1er83kY7xLRGoA (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 03 Jul 2016 11:15:18 -0600 (MDT) X-Barracuda-Envelope-From: aserdean@cloudbasesolutions.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO cbssmtp1.cloudbase.local) (91.232.152.5) by mx3-pf3.cudamail.com with SMTP; 3 Jul 2016 17:15:17 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at cloudbasesolutions.com designates 91.232.152.5 as permitted sender) X-Barracuda-Apparent-Source-IP: 91.232.152.5 X-Barracuda-RBL-IP: 91.232.152.5 Received: from localhost (localhost [127.0.0.1]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id 4869F41815 for ; Sun, 3 Jul 2016 20:15:16 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from cbssmtp1.cloudbase.local ([127.0.0.1]) by localhost (cbssmtp1.cloudbase.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id immvYMNEqMbP for ; Sun, 3 Jul 2016 20:14:55 +0300 (EEST) Received: from CBSEX1.cloudbase.local (unknown [10.77.78.3]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id DBAC63FBA0 for ; Sun, 3 Jul 2016 20:14:55 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0301.000; Sun, 3 Jul 2016 19:14:55 +0200 X-CudaMail-Envelope-Sender: aserdean@cloudbasesolutions.com From: Alin Serdean To: "dev@openvswitch.org" X-CudaMail-MID: CM-V3-702008894 X-CudaMail-DTE: 070316 X-CudaMail-Originating-IP: 91.232.152.5 Thread-Topic: [PATCH] build: Skip check-export-symbol on Windows X-ASG-Orig-Subj: [##CM-V3-702008894##][PATCH] build: Skip check-export-symbol on Windows Thread-Index: AQHR1U5qrf4zM9VphUmLGMGOYjA5ig== Date: Sun, 3 Jul 2016 17:14:54 +0000 Message-ID: <1467566099-9164-1-git-send-email-aserdean@cloudbasesolutions.com> Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-GBUdb-Analysis: 0, 91.232.152.5, Ugly c=0.323114 p=-0.304348 Source Normal X-MessageSniffer-Rules: 0-0-0-4497-c X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1467566118 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.30980 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS Subject: [ovs-dev] [PATCH] build: Skip check-export-symbol on Windows X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" This patch makes automake skip the function 'check-export-symbol' under Windows. The main reason is that msys does not have an implementation of rev used by: https://github.com/openvswitch/ovs/blob/master/datapath/Makefile.am#L34 and can be seen on: https://ci.appveyor.com/project/blp/ovs/build/1.0.1851#L322 Signed-off-by: Alin Gabriel Serdean Co-authored-by: Ben Pfaff --- datapath/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/Makefile.am b/datapath/Makefile.am index 458fa5b..f2a85bc 100644 --- a/datapath/Makefile.am +++ b/datapath/Makefile.am @@ -30,6 +30,7 @@ print-build-modules: fi @echo "$(build_modules)" | tr '_' '-'; +if !WIN32 COMPAT_GET_FUNCTIONS := find $(top_srcdir)/datapath/linux/compat -name "*.h" \ -exec sed -n '/^[a-z][a-z]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p; /^struct [a-z0-9_][a-z0-9_]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p' {} \; | tr -d '*' | cut -d '(' -f1 | rev | cut -d ' ' -f1 | rev COMPAT_GET_EXPORTS := find $(top_srcdir)/datapath/linux/compat -name "*.c" \ @@ -56,3 +57,4 @@ check-export-symbol: done all-local: check-export-symbol +endif