[ovs-dev] build: Skip check-export-symbol on Windows
diff mbox

Message ID 1467566099-9164-1-git-send-email-aserdean@cloudbasesolutions.com
State Accepted
Delegated to: Ben Pfaff
Headers show

Commit Message

Alin Serdean July 3, 2016, 5:14 p.m. UTC
This patch makes automake skip the function 'check-export-symbol' under
Windows.

The main reason is that msys does not have an implementation of rev
used by:
https://github.com/openvswitch/ovs/blob/master/datapath/Makefile.am#L34

and can be seen on:
https://ci.appveyor.com/project/blp/ovs/build/1.0.1851#L322

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Co-authored-by: Ben Pfaff <blp@ovn.org>
---
 datapath/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ben Pfaff July 3, 2016, 7:35 p.m. UTC | #1
On Sun, Jul 03, 2016 at 05:14:54PM +0000, Alin Serdean wrote:
> This patch makes automake skip the function 'check-export-symbol' under
> Windows.
> 
> The main reason is that msys does not have an implementation of rev
> used by:
> https://github.com/openvswitch/ovs/blob/master/datapath/Makefile.am#L34
> 
> and can be seen on:
> https://ci.appveyor.com/project/blp/ovs/build/1.0.1851#L322
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
> Co-authored-by: Ben Pfaff <blp@ovn.org>

Applied, thanks!

Patch
diff mbox

diff --git a/datapath/Makefile.am b/datapath/Makefile.am
index 458fa5b..f2a85bc 100644
--- a/datapath/Makefile.am
+++ b/datapath/Makefile.am
@@ -30,6 +30,7 @@  print-build-modules:
 	fi
 	@echo "$(build_modules)" | tr '_' '-';
 
+if !WIN32
 COMPAT_GET_FUNCTIONS := find $(top_srcdir)/datapath/linux/compat -name "*.h" \
 	-exec sed -n '/^[a-z][a-z]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p; /^struct [a-z0-9_][a-z0-9_]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p' {} \; | tr -d '*' | cut -d '(' -f1 | rev | cut -d ' ' -f1 | rev
 COMPAT_GET_EXPORTS := find $(top_srcdir)/datapath/linux/compat -name "*.c" \
@@ -56,3 +57,4 @@  check-export-symbol:
 	done
 
 all-local: check-export-symbol
+endif