diff mbox

[ovs-dev] bridge: fix windows build

Message ID 1467249392-792-1-git-send-email-aatteka@ovn.org
State Accepted
Headers show

Commit Message

Ansis Atteka June 30, 2016, 1:16 a.m. UTC
Patch 81d2f75c (bridge: allow OVS to interact with controller
through sockets outside run dir) broke windows build. This patch
fixes that.

Signed-off-by: Ansis Atteka <aatteka@ovn.org>
---
 lib/daemon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sairam Venugopal June 30, 2016, 1:24 a.m. UTC | #1
Thanks for fixing this. I just sent out a patch for fixing the same.

Acked-by: Sairam Venugopal <vsairam@vmware.com>



On 6/29/16, 6:16 PM, "Ansis Atteka" <aatteka@ovn.org> wrote:

>Patch 81d2f75c (bridge: allow OVS to interact with controller
>through sockets outside run dir) broke windows build. This patch
>fixes that.
>
>Signed-off-by: Ansis Atteka <aatteka@ovn.org>
>---
> lib/daemon.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/daemon.h b/lib/daemon.h
>index b035055..bfa0640 100644
>--- a/lib/daemon.h
>+++ b/lib/daemon.h
>@@ -102,7 +102,7 @@ pid_t read_pidfile(const char *name);
> 
> #define DAEMON_LONG_OPTIONS
> \
>         {"detach",             no_argument, NULL, OPT_DETACH},
> \
>-        {"no-self-confinement" no_argument, NULL,
>OPT_NO_SELF_CONFINEMENT}, \
>+        {"no-self-confinement", no_argument, NULL,
>OPT_NO_SELF_CONFINEMENT}, \
>         {"no-chdir",           no_argument, NULL, OPT_NO_CHDIR},
> \
>         {"pidfile",            optional_argument, NULL, OPT_PIDFILE},
> \
>         {"pipe-handle",        required_argument, NULL,
>OPT_PIPE_HANDLE}, \
>-- 
>2.7.4
>
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=gJ-BS45dg_uOcOZIBwuM46WcdURY-5
>7p02UAsBQHi0A&s=aX_H-21SFONJ-j0jLo1qXlx_eifPlDI-uULSVo0crxg&e=
Ansis June 30, 2016, 1:27 a.m. UTC | #2
On 29 June 2016 at 18:24, Sairam Venugopal <vsairam@vmware.com> wrote:

> Thanks for fixing this. I just sent out a patch for fixing the same.
>
> Acked-by: Sairam Venugopal <vsairam@vmware.com>
>
Thanks, for review. I pushed it.

Sorry for wasting your cycles on this.

>
>
>
> On 6/29/16, 6:16 PM, "Ansis Atteka" <aatteka@ovn.org> wrote:
>
> >Patch 81d2f75c (bridge: allow OVS to interact with controller
> >through sockets outside run dir) broke windows build. This patch
> >fixes that.
> >
> >Signed-off-by: Ansis Atteka <aatteka@ovn.org>
> >---
> > lib/daemon.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/daemon.h b/lib/daemon.h
> >index b035055..bfa0640 100644
> >--- a/lib/daemon.h
> >+++ b/lib/daemon.h
> >@@ -102,7 +102,7 @@ pid_t read_pidfile(const char *name);
> >
> > #define DAEMON_LONG_OPTIONS
> > \
> >         {"detach",             no_argument, NULL, OPT_DETACH},
> > \
> >-        {"no-self-confinement" no_argument, NULL,
> >OPT_NO_SELF_CONFINEMENT}, \
> >+        {"no-self-confinement", no_argument, NULL,
> >OPT_NO_SELF_CONFINEMENT}, \
> >         {"no-chdir",           no_argument, NULL, OPT_NO_CHDIR},
> > \
> >         {"pidfile",            optional_argument, NULL, OPT_PIDFILE},
> > \
> >         {"pipe-handle",        required_argument, NULL,
> >OPT_PIPE_HANDLE}, \
> >--
> >2.7.4
> >
> >_______________________________________________
> >dev mailing list
> >dev@openvswitch.org
> >
> https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
> >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
> >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=gJ-BS45dg_uOcOZIBwuM46WcdURY-5
> >7p02UAsBQHi0A&s=aX_H-21SFONJ-j0jLo1qXlx_eifPlDI-uULSVo0crxg&e=
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/lib/daemon.h b/lib/daemon.h
index b035055..bfa0640 100644
--- a/lib/daemon.h
+++ b/lib/daemon.h
@@ -102,7 +102,7 @@  pid_t read_pidfile(const char *name);
 
 #define DAEMON_LONG_OPTIONS                                               \
         {"detach",             no_argument, NULL, OPT_DETACH},            \
-        {"no-self-confinement" no_argument, NULL, OPT_NO_SELF_CONFINEMENT}, \
+        {"no-self-confinement", no_argument, NULL, OPT_NO_SELF_CONFINEMENT}, \
         {"no-chdir",           no_argument, NULL, OPT_NO_CHDIR},          \
         {"pidfile",            optional_argument, NULL, OPT_PIDFILE},     \
         {"pipe-handle",        required_argument, NULL, OPT_PIPE_HANDLE}, \