diff mbox

[U-Boot,2/3] cmd: blkcache: simplify sub-command handling

Message ID 1459607834-5454-3-git-send-email-eric@nelint.com
State Accepted
Commit 195c94a24071fa6be913219e0d98bb210b06ccb5
Delegated to: Tom Rini
Headers show

Commit Message

Eric Nelson April 2, 2016, 2:37 p.m. UTC 
Signed-off-by: Eric Nelson <eric@nelint.com>
---
 cmd/blkcache.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Stephen Warren April 4, 2016, 5:39 p.m. UTC | #1 
On 04/02/2016 08:37 AM, Eric Nelson wrote:

The series,
Acked-by: Stephen Warren <swarren@nvidia.com>

One nit below:

> diff --git a/cmd/blkcache.c b/cmd/blkcache.c

> @@ -73,12 +73,10 @@ static int do_blkcache(cmd_tbl_t *cmdtp, int flag,
>
>   	c = find_cmd_tbl(argv[0], &cmd_blkc_sub[0], ARRAY_SIZE(cmd_blkc_sub));
>
> -	if (c)

I'd suggest removing that blank line too.
Tom Rini April 12, 2016, 2:28 a.m. UTC | #2 
On Sat, Apr 02, 2016 at 07:37:13AM -0700, Eric Nelson wrote:

> Signed-off-by: Eric Nelson <eric@nelint.com>
> Acked-by: Stephen Warren <swarren@nvidia.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/cmd/blkcache.c b/cmd/blkcache.c
index d97bed5..1338dbd 100644
--- a/cmd/blkcache.c
+++ b/cmd/blkcache.c
@@ -73,12 +73,10 @@  static int do_blkcache(cmd_tbl_t *cmdtp, int flag,
 
 	c = find_cmd_tbl(argv[0], &cmd_blkc_sub[0], ARRAY_SIZE(cmd_blkc_sub));
 
-	if (c)
-		return c->cmd(cmdtp, flag, argc, argv);
-	else
+	if (!c)
 		return CMD_RET_USAGE;
 
-	return 0;
+	return c->cmd(cmdtp, flag, argc, argv);
 }
 
 U_BOOT_CMD(