Fix PR68621 - Patchwork

Message ID	CY1PR1201MB10983BA371E26F98074759978FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com
State	New
Headers	show Return-Path: <gcc-patches-return-422483-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=GzB/3oFDAvc2X1uywTvc3YSB6i/iguh0DgM6XWwZOy40Oh7Z3aJ1E mJnU7Q4MsAP90/yfB2LwWgBqYYWlGP7uU6Sv8tRMC4WMPRRXVbGNunm650eWFKGR OXz+IEed0YVxf9dMKheE2HZIfhDLiLs27sKrXjWMB+Cv0skmquk1Cw= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org From: "Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com> To: Marek Polacek <polacek@redhat.com> CC: "Richard Beiner (richard.guenther@gmail.com)" <richard.guenther@gmail.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, "hjl.tools@gmail.com" <hjl.tools@gmail.com> Subject: RE: [PATCH] Fix PR68621 Date: Tue, 1 Mar 2016 16:59:40 +0000 Message-ID: <CY1PR1201MB10983BA371E26F98074759978FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com> References: <CY1PR1201MB1098D406F5A2DEE1256274F88FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com> <20160301165238.GA14947@redhat.com> In-Reply-To: <20160301165238.GA14947@redhat.com> spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0

Message ID

CY1PR1201MB10983BA371E26F98074759978FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender:from
	:to:cc:subject:date:message-id:references:in-reply-to
	:content-type:content-transfer-encoding:mime-version; q=dns; s=
	default; b=GzB/3oFDAvc2X1uywTvc3YSB6i/iguh0DgM6XWwZOy40Oh7Z3aJ1E
	mJnU7Q4MsAP90/yfB2LwWgBqYYWlGP7uU6Sv8tRMC4WMPRRXVbGNunm650eWFKGR
	OXz+IEed0YVxf9dMKheE2HZIfhDLiLs27sKrXjWMB+Cv0skmquk1Cw=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
From: "Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>
To: Marek Polacek <polacek@redhat.com>
CC: "Richard Beiner
	(richard.guenther@gmail.com)"	<richard.guenther@gmail.com>,
	"gcc-patches@gcc.gnu.org"	<gcc-patches@gcc.gnu.org>,
	"hjl.tools@gmail.com" <hjl.tools@gmail.com>
Subject: RE: [PATCH] Fix PR68621
Date: Tue, 1 Mar 2016 16:59:40 +0000
Message-ID: <CY1PR1201MB10983BA371E26F98074759978FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com>
References: <CY1PR1201MB1098D406F5A2DEE1256274F88FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com>
	<20160301165238.GA14947@redhat.com>
In-Reply-To: <20160301165238.GA14947@redhat.com>
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2016 16:59:40.7102
	(UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR1201MB1098
X-IsSubscribed: yes

Commit Message

Kumar, Venkataramanan March 1, 2016, 4:59 p.m. UTC

Hi Marek, 

Thank you for pointing out.  Yes I should add.


Regards,
Venkat.

> -----Original Message-----
> From: Marek Polacek [mailto:polacek@redhat.com]
> Sent: Tuesday, March 01, 2016 10:23 PM
> To: Kumar, Venkataramanan
> Cc: Richard Beiner (richard.guenther@gmail.com); gcc-patches@gcc.gnu.org;
> hjl.tools@gmail.com
> Subject: Re: [PATCH] Fix PR68621
> 
> On Tue, Mar 01, 2016 at 04:48:40PM +0000, Kumar, Venkataramanan wrote:
> >  /* { dg-do compile } */
> > -/* { dg-options "-Ofast -fdump-tree-ifcvt-details -fno-common -ftree-
> loop-if-convert-stores" } */
> > +/* { dg-options "-Ofast -fdump-tree-ifcvt-details -ftree-loop-if-convert-
> stores" } */
> >
> >  #define LEN 4096
> > - __attribute__((aligned (32))) float array[LEN];
> > + __attribute__((visibility("hidden"), aligned (32))) float array[LEN] = {};
> 
> Don't you need
> /* { dg-require-visibility "" } */
> if you use __attribute__ ((visibility))?
> 
> 	Marek

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 82e538e..f6bcb07 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@ 
+2016-03-01  Venkataramanan Kumar  <Venkataramanan.kumar@amd.com>
+
+       PR tree-optimization/68621
+       * gcc.dg/tree-ssa/ifc-8.c: Adjust test.
+
 2016-02-29  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

        PR target/70011
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c
index 89a3410..81a4075 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c
@@ -1,9 +1,10 @@ 

 /* { dg-do compile } */
-/* { dg-options "-Ofast -fdump-tree-ifcvt-details -fno-common -ftree-loop-if-convert-stores" } */
+/* { dg-options "-Ofast -fdump-tree-ifcvt-details -ftree-loop-if-convert-stores" } */
+/* { dg-require-visibility "" } */

 #define LEN 4096
- __attribute__((aligned (32))) float array[LEN];
+ __attribute__((visibility("hidden"), aligned (32))) float array[LEN] = {};

 void test ()
 {