| Message ID | 1450757888-14216-1-git-send-email-igal.liberman@freescale.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Scott Wood |
| Headers | show |
On Tue, 2015-12-22 at 06:18 +0200, igal.liberman@freescale.com wrote: > From: Igal Liberman <igal.liberman@freescale.com> > > Signed-off-by: Igal Liberman <igal.liberman@freescale.com> > --- > .../devicetree/bindings/powerpc/fsl/fman.txt | 39 ++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > index 1fc5328..7a6d7c3 100644 > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > @@ -315,6 +315,16 @@ PROPERTIES > Value type: <phandle> > Definition: A phandle for 1EEE1588 timer. > > +- pcsphy-handle > + Usage required for "fsl,fman-memac" MACs > + Value type: <phandle> > + Definition: A phandle for pcsphy. > + > +- tbi-handle > + Usage required for "fsl,fman-dtsec" MACs > + Value type: <phandle> > + Definition: A phandle for tbiphy. > + > EXAMPLE > > fman1_tx28: port@a8000 { > @@ -340,6 +350,7 @@ ethernet@e0000 { > reg = <0xe0000 0x1000>; > fsl,fman-ports = <&fman1_rx8 &fman1_tx28>; > ptp-timer = <&ptp-timer>; > + tbi-handle = <&tbi0>; > }; > > ============================================================================ > @@ -415,6 +426,13 @@ PROPERTIES > The settings and programming routines for internal/external > MDIO are different. Must be included for internal MDIO. > > +For internal PHY device on internal mdio bus, a PHY node should be created. > +See the definition of the PHY node in booting-without-of.txt for an > +example of how to define a PHY (Internal PHY has no interrupt line). > +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY. > +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is PCS PHY, > + PCS PHY addr must be '0'. Will this replace the need for fixed PHYs ? Jocke
Regards, Igal Liberman > -----Original Message----- > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com] > Sent: Tuesday, December 22, 2015 5:57 PM > To: linuxppc-dev@lists.ozlabs.org; Liberman Igal-B31950 > <Igal.Liberman@freescale.com>; devicetree@vger.kernel.org > Cc: Wood Scott-B07421 <scottwood@freescale.com>; Xie Shaohui-B21989 > <Shaohui.Xie@freescale.com>; Bucur Madalin-Cristian-B32716 > <madalin.bucur@freescale.com> > Subject: Re: [PATCH] powerpc/fsl: Update fman dt binding with pcs-phy and > tbi-phy > > On Tue, 2015-12-22 at 06:18 +0200, igal.liberman@freescale.com wrote: > > From: Igal Liberman <igal.liberman@freescale.com> > > > > Signed-off-by: Igal Liberman <igal.liberman@freescale.com> > > --- > > .../devicetree/bindings/powerpc/fsl/fman.txt | 39 > > ++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > index 1fc5328..7a6d7c3 100644 > > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > @@ -315,6 +315,16 @@ PROPERTIES > > Value type: <phandle> > > Definition: A phandle for 1EEE1588 timer. > > > > +- pcsphy-handle > > + Usage required for "fsl,fman-memac" MACs > > + Value type: <phandle> > > + Definition: A phandle for pcsphy. > > + > > +- tbi-handle > > + Usage required for "fsl,fman-dtsec" MACs > > + Value type: <phandle> > > + Definition: A phandle for tbiphy. > > + > > EXAMPLE > > > > fman1_tx28: port@a8000 { > > @@ -340,6 +350,7 @@ ethernet@e0000 { > > reg = <0xe0000 0x1000>; > > fsl,fman-ports = <&fman1_rx8 &fman1_tx28>; > > ptp-timer = <&ptp-timer>; > > + tbi-handle = <&tbi0>; > > }; > > > > > > > ========================================================== > ============ > > ====== > > @@ -415,6 +426,13 @@ PROPERTIES > > The settings and programming routines for internal/external > > MDIO are different. Must be included for internal MDIO. > > > > +For internal PHY device on internal mdio bus, a PHY node should be > created. > > +See the definition of the PHY node in booting-without-of.txt for an > > +example of how to define a PHY (Internal PHY has no interrupt line). > > +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY. > > +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is > > +PCS PHY, > > + PCS PHY addr must be '0'. > > Will this replace the need for fixed PHYs ? > Hi Jocke, No, this is internal PCS configuration which required for both types of links. The configuration for fixed links is different, but we use the same method. Igal > Jocke
On Tue, 2015-12-22 at 06:18 +0200, igal.liberman@freescale.com wrote: > From: Igal Liberman <igal.liberman@freescale.com> > > Signed-off-by: Igal Liberman <igal.liberman@freescale.com> > --- > .../devicetree/bindings/powerpc/fsl/fman.txt | 39 > ++++++++++++++++++++ > 1 file changed, 39 insertions(+) Some description in the log would be nice, especially why it can't use phy -handle > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > index 1fc5328..7a6d7c3 100644 > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > @@ -315,6 +315,16 @@ PROPERTIES > Value type: <phandle> > Definition: A phandle for 1EEE1588 timer. > > +- pcsphy-handle > + Usage required for "fsl,fman-memac" MACs > + Value type: <phandle> > + Definition: A phandle for pcsphy. > + > +- tbi-handle > + Usage required for "fsl,fman-dtsec" MACs > + Value type: <phandle> > + Definition: A phandle for tbiphy. > + > EXAMPLE > > fman1_tx28: port@a8000 { > @@ -340,6 +350,7 @@ ethernet@e0000 { > reg = <0xe0000 0x1000>; > fsl,fman-ports = <&fman1_rx8 &fman1_tx28>; > ptp-timer = <&ptp-timer>; > + tbi-handle = <&tbi0>; > }; > > =========================================================================== > = > @@ -415,6 +426,13 @@ PROPERTIES > The settings and programming routines for internal/external > MDIO are different. Must be included for internal MDIO. > > +For internal PHY device on internal mdio bus, a PHY node should be created. > +See the definition of the PHY node in booting-without-of.txt for an > +example of how to define a PHY (Internal PHY has no interrupt line). > +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY. > +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is PCS > PHY, > + PCS PHY addr must be '0'. > + > EXAMPLE > > Example for FMan v2 external MDIO: > @@ -425,12 +443,28 @@ mdio@f1000 { > interrupts = <101 2 0 0>; > }; > > +Example for FMan v2 internal MDIO: > + > +mdio@e3120 { > + compatible = "fsl,fman-mdio"; > + reg = <0xe3120 0xee0>; > + fsl,fman-internal-mdio; > + > + tbi1: tbi-phy@8 { > + reg = <0x8>; > + device_type = "tbi-phy"; > + }; > +}; > + > Example for FMan v3 internal MDIO: > > mdio@f1000 { > compatible = "fsl,fman-memac-mdio"; > reg = <0xf1000 0x1000>; > fsl,fman-internal-mdio; > + > + pcsphy6: ethernet-phy@0 { > + reg = <0x0>; > }; missing } -Scott
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt index 1fc5328..7a6d7c3 100644 --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt @@ -315,6 +315,16 @@ PROPERTIES Value type: <phandle> Definition: A phandle for 1EEE1588 timer. +- pcsphy-handle + Usage required for "fsl,fman-memac" MACs + Value type: <phandle> + Definition: A phandle for pcsphy. + +- tbi-handle + Usage required for "fsl,fman-dtsec" MACs + Value type: <phandle> + Definition: A phandle for tbiphy. + EXAMPLE fman1_tx28: port@a8000 { @@ -340,6 +350,7 @@ ethernet@e0000 { reg = <0xe0000 0x1000>; fsl,fman-ports = <&fman1_rx8 &fman1_tx28>; ptp-timer = <&ptp-timer>; + tbi-handle = <&tbi0>; }; ============================================================================ @@ -415,6 +426,13 @@ PROPERTIES The settings and programming routines for internal/external MDIO are different. Must be included for internal MDIO. +For internal PHY device on internal mdio bus, a PHY node should be created. +See the definition of the PHY node in booting-without-of.txt for an +example of how to define a PHY (Internal PHY has no interrupt line). +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY. +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is PCS PHY, + PCS PHY addr must be '0'. + EXAMPLE Example for FMan v2 external MDIO: @@ -425,12 +443,28 @@ mdio@f1000 { interrupts = <101 2 0 0>; }; +Example for FMan v2 internal MDIO: + +mdio@e3120 { + compatible = "fsl,fman-mdio"; + reg = <0xe3120 0xee0>; + fsl,fman-internal-mdio; + + tbi1: tbi-phy@8 { + reg = <0x8>; + device_type = "tbi-phy"; + }; +}; + Example for FMan v3 internal MDIO: mdio@f1000 { compatible = "fsl,fman-memac-mdio"; reg = <0xf1000 0x1000>; fsl,fman-internal-mdio; + + pcsphy6: ethernet-phy@0 { + reg = <0x0>; }; ============================================================================= @@ -568,6 +602,7 @@ fman@400000 { cell-index = <0>; reg = <0xe0000 0x1000>; fsl,fman-ports = <&fman1_rx_0x8 &fman1_tx_0x28>; + tbi-handle = <&tbi5>; }; ethernet@e2000 { @@ -575,6 +610,7 @@ fman@400000 { cell-index = <1>; reg = <0xe2000 0x1000>; fsl,fman-ports = <&fman1_rx_0x9 &fman1_tx_0x29>; + tbi-handle = <&tbi6>; }; ethernet@e4000 { @@ -582,6 +618,7 @@ fman@400000 { cell-index = <2>; reg = <0xe4000 0x1000>; fsl,fman-ports = <&fman1_rx_0xa &fman1_tx_0x2a>; + tbi-handle = <&tbi7>; }; ethernet@e6000 { @@ -589,6 +626,7 @@ fman@400000 { cell-index = <3>; reg = <0xe6000 0x1000>; fsl,fman-ports = <&fman1_rx_0xb &fman1_tx_0x2b>; + tbi-handle = <&tbi8>; }; ethernet@e8000 { @@ -596,6 +634,7 @@ fman@400000 { cell-index = <4>; reg = <0xf0000 0x1000>; fsl,fman-ports = <&fman1_rx_0xc &fman1_tx_0x2c>; + tbi-handle = <&tbi9>; ethernet@f0000 { cell-index = <8>;