diff mbox

[ovs-dev] datapath-windows: reduce padding size in _OVS_PACKET_HDR_INFO

Message ID 1449529983-43632-1-git-send-email-nithin@vmware.com
State Accepted
Headers show

Commit Message

Nithin Raju Dec. 7, 2015, 11:13 p.m. UTC
Fixing a little buglet from commit: efee3309.

Signed-by: Nithin Raju <nithin@vmware.com>
---
 datapath-windows/ovsext/NetProto.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sairam Venugopal Dec. 8, 2015, 7:05 p.m. UTC | #1
Acked-by: Sairam Venugopal <vsairam@vmware.com>


On 12/7/15, 3:13 PM, "Nithin Raju" <nithin@vmware.com> wrote:

>Fixing a little buglet from commit: efee3309.
>
>Signed-by: Nithin Raju <nithin@vmware.com>
>---
> datapath-windows/ovsext/NetProto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/NetProto.h
>b/datapath-windows/ovsext/NetProto.h
>index a364869..c60081a 100644
>--- a/datapath-windows/ovsext/NetProto.h
>+++ b/datapath-windows/ovsext/NetProto.h
>@@ -205,7 +205,7 @@ typedef union _OVS_PACKET_HDR_INFO {
>         UINT16 tcpCsumNeeded:1;
>         UINT16 udpCsumNeeded:1;
>         UINT16 udpCsumZero:1;
>-        UINT16 pad:9;
>+        UINT16 pad:8;
>     } ;
>     UINT64 value;
> } OVS_PACKET_HDR_INFO, *POVS_PACKET_HDR_INFO;
>-- 
>1.8.5.6
>
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=Ae1JC0tageL-QrQatbFKCuAC9qm5z-
>w-Z8-1yYLpkY0&s=nByFJSJRKBYjU49mz2AkyXr8YGHGM7coTHMiH26BBDo&e=
Alin Serdean Dec. 10, 2015, 6:02 p.m. UTC | #2
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>



> -----Mesaj original-----

> De la: dev [mailto:dev-bounces@openvswitch.org] În numele Sairam

> Venugopal

> Trimis: Tuesday, December 8, 2015 9:06 PM

> Către: Nithin Raju <nithin@vmware.com>; dev@openvswitch.org

> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: reduce padding size in

> _OVS_PACKET_HDR_INFO

> 

> Acked-by: Sairam Venugopal <vsairam@vmware.com>

> 

> 

> On 12/7/15, 3:13 PM, "Nithin Raju" <nithin@vmware.com> wrote:

> 

> >Fixing a little buglet from commit: efee3309.

> >

> >Signed-by: Nithin Raju <nithin@vmware.com>

> >---

> > datapath-windows/ovsext/NetProto.h | 2 +-

> > 1 file changed, 1 insertion(+), 1 deletion(-)

> >

> >diff --git a/datapath-windows/ovsext/NetProto.h

> >b/datapath-windows/ovsext/NetProto.h

> >index a364869..c60081a 100644

> >--- a/datapath-windows/ovsext/NetProto.h

> >+++ b/datapath-windows/ovsext/NetProto.h

> >@@ -205,7 +205,7 @@ typedef union _OVS_PACKET_HDR_INFO {

> >         UINT16 tcpCsumNeeded:1;

> >         UINT16 udpCsumNeeded:1;

> >         UINT16 udpCsumZero:1;

> >-        UINT16 pad:9;

> >+        UINT16 pad:8;

> >     } ;

> >     UINT64 value;

> > } OVS_PACKET_HDR_INFO, *POVS_PACKET_HDR_INFO;

> >--

> >1.8.5.6

> >

> >_______________________________________________

> >dev mailing list

> >dev@openvswitch.org

> >https://urldefense.proofpoint.com/v2/url?u=http-

> 3A__openvswitch.org_mai

> >lma

> >n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-

> YihVMNtXt-uEs&r

> >=Dc

> >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=Ae1JC0tageL-

> QrQatbFKCuAC9qm

> >5z- w-Z8-

> 1yYLpkY0&s=nByFJSJRKBYjU49mz2AkyXr8YGHGM7coTHMiH26BBDo&e=

> 

> _______________________________________________

> dev mailing list

> dev@openvswitch.org

> http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff Dec. 23, 2015, 5:23 p.m. UTC | #3
On Mon, Dec 07, 2015 at 03:13:03PM -0800, Nithin Raju wrote:
> Fixing a little buglet from commit: efee3309.
> 
> Signed-by: Nithin Raju <nithin@vmware.com>

Thanks Nithin.  I'm going to assume that's a typo for Signed-off-by (I
fixed it).

I also transformed your commit message into our new "Fixes" tag:

datapath-windows: Reduce padding size in _OVS_PACKET_HDR_INFO.

Fixes: efee3309 ("datapath-windows: Support for OVS_KEY_ATTR_SCTP attribute")
Signed-off-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
diff mbox

Patch

diff --git a/datapath-windows/ovsext/NetProto.h b/datapath-windows/ovsext/NetProto.h
index a364869..c60081a 100644
--- a/datapath-windows/ovsext/NetProto.h
+++ b/datapath-windows/ovsext/NetProto.h
@@ -205,7 +205,7 @@  typedef union _OVS_PACKET_HDR_INFO {
         UINT16 tcpCsumNeeded:1;
         UINT16 udpCsumNeeded:1;
         UINT16 udpCsumZero:1;
-        UINT16 pad:9;
+        UINT16 pad:8;
     } ;
     UINT64 value;
 } OVS_PACKET_HDR_INFO, *POVS_PACKET_HDR_INFO;