diff mbox

[ovs-dev] netdev_dpdk: pci_dev pointer check.

Message ID 1449127816-31983-1-git-send-email-michalx.weglicki@intel.com
State Accepted
Headers show

Commit Message

Weglicki, MichalX Dec. 3, 2015, 7:30 a.m. UTC 
This change prevents netdev_dpdk from accessing pointer
which is not valid.

Signed-off-by: Michal Weglicki <michalx.weglicki@intel.com>
---
 lib/netdev-dpdk.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Pravin B Shelar Dec. 22, 2015, 8:52 p.m. UTC | #1 
On Wed, Dec 2, 2015 at 11:30 PM, mweglicx <michalx.weglicki@intel.com> wrote:
> This change prevents netdev_dpdk from accessing pointer
> which is not valid.
>
> Signed-off-by: Michal Weglicki <michalx.weglicki@intel.com>

Thanks. I applied the patch to master and branch 2.[3-5].

Thanks,
Pravin.
diff mbox

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 4658416..2831a1b 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1690,8 +1690,12 @@  netdev_dpdk_get_status(const struct netdev *netdev_, struct smap *args)
     smap_add_format(args, "max_vfs", "%u", dev_info.max_vfs);
     smap_add_format(args, "max_vmdq_pools", "%u", dev_info.max_vmdq_pools);
 
-    smap_add_format(args, "pci-vendor_id", "0x%u", dev_info.pci_dev->id.vendor_id);
-    smap_add_format(args, "pci-device_id", "0x%x", dev_info.pci_dev->id.device_id);
+    if (dev_info.pci_dev) {
+        smap_add_format(args, "pci-vendor_id", "0x%u",
+                        dev_info.pci_dev->id.vendor_id);
+        smap_add_format(args, "pci-device_id", "0x%x",
+                        dev_info.pci_dev->id.device_id);
+    }
 
     return 0;
 }