diff mbox

[ovs-dev,2/2] TODO.md: Remove old item.

Message ID 1446847231-35606-2-git-send-email-jpettit@ovn.org
State Accepted
Headers show

Commit Message

Justin Pettit Nov. 6, 2015, 10 p.m. UTC
The patchwork instance has been recreated, so this doesn't point any
place valid.

Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 TODO.md |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

Comments

Russell Bryant Nov. 6, 2015, 10:27 p.m. UTC | #1
On 11/06/2015 05:00 PM, Justin Pettit wrote:
> The patchwork instance has been recreated, so this doesn't point any
> place valid.
> 
> Signed-off-by: Justin Pettit <jpettit@ovn.org>
> ---
>  TODO.md |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/TODO.md b/TODO.md
> index e2db33b..b4542b7 100644
> --- a/TODO.md
> +++ b/TODO.md
> @@ -68,15 +68,6 @@ UDP or DTLS.  One place to start would be to implement a datagram
>  abstraction library for OVS analogous to the ``stream'' library
>  that already abstracts TCP, SSL, and other stream protocols.
>  
> -Controller connection logging to pcap file
> -------------------------------------------
> -
> -http://patchwork.openvswitch.org/patch/2249/ is an RFC patch that
> -allows the switch to record the traffic on OpenFlow controller
> -connections to a pcap file for later analysis. The patch lacks a good
> -way to enable and disable the feature. The task here would be to add
> -that and repost the patch.
> -
>  Basic OpenFlow 1.4 support
>  --------------------------
>  
> 

If the only issue was the bad link, I think it was:

http://openvswitch.org/pipermail/dev/2013-November/034299.html

Of course, if you don't think the todo item is interesting anymore in
general, removing seems fine.  In either case:

Acked-by: Russell Bryant <rbryant@redhat.com>
Ben Pfaff Nov. 6, 2015, 10:53 p.m. UTC | #2
On Fri, Nov 06, 2015 at 02:00:31PM -0800, Justin Pettit wrote:
> The patchwork instance has been recreated, so this doesn't point any
> place valid.
> 
> Signed-off-by: Justin Pettit <jpettit@ovn.org>

Acked-by: Ben Pfaff <blp@ovn.org>
Justin Pettit Nov. 7, 2015, 12:35 a.m. UTC | #3
> On Nov 6, 2015, at 2:27 PM, Russell Bryant <rbryant@redhat.com> wrote:
> 
> If the only issue was the bad link, I think it was:
> 
> http://openvswitch.org/pipermail/dev/2013-November/034299.html
> 
> Of course, if you don't think the todo item is interesting anymore in
> general, removing seems fine.  In either case:

I checked with Ben, and he wanted to drop it entirely.

Thanks for the reviews.  I pushed the series with yours and Ben's acks.

--Justin
diff mbox

Patch

diff --git a/TODO.md b/TODO.md
index e2db33b..b4542b7 100644
--- a/TODO.md
+++ b/TODO.md
@@ -68,15 +68,6 @@  UDP or DTLS.  One place to start would be to implement a datagram
 abstraction library for OVS analogous to the ``stream'' library
 that already abstracts TCP, SSL, and other stream protocols.
 
-Controller connection logging to pcap file
-------------------------------------------
-
-http://patchwork.openvswitch.org/patch/2249/ is an RFC patch that
-allows the switch to record the traffic on OpenFlow controller
-connections to a pcap file for later analysis. The patch lacks a good
-way to enable and disable the feature. The task here would be to add
-that and repost the patch.
-
 Basic OpenFlow 1.4 support
 --------------------------